Skip to content

Nonsensical behavior on attempt to share already saved diff, causing deletion never asked for #141

@php4fan

Description

@php4fan

Steps to reproduce I:

  1. Go to https://editor.mergely.com/
  2. Enter some text on both sides
  3. Go to File->Share and click "Save for sharing"
  4. Do File->Share again

Expected: nothing much should happen. Maybe copy the url to the clipbpoard or tell me that the current diff is already saved and the url for sharing it is in my very address bar

Observed: This prompt:

image

and of course the "Delete permanently" does delete the diff. But I never asked to. I clicked on "Share".

Steps to reproduce II:

  1. Go to https://editor.mergely.com/
  2. Enter some text on both sides
  3. Go to File->Share and click "Save for sharing"
  4. Further edit at least one side
  5. Do File->Share again

Expected:
There are a few reasonable options here. What File->Share should accomplish in this scenario is to save the new diff and update the URL. But I was editing a previously saved one so I should probably get some sort of warning.
Let's say that at step 2 I had some texts in the editor and after step 3 it got saved as editor.mergely.com/ABCDE.
The simplest sensible behavior that I can think of for what happens after step 5 is that:

  • the new diff gets saved with a new id
  • the url in the browser's address bar gets updated to editor.mergely.com/FGHIJ
  • optionally (but very recommended) a popup or flash message shows up alerting me that the url has changed and that the URL of the old diff that I previously saved is editor.mergely.com/ABCDE.

No deletion should be involved

Observed:
The same nonsense as in case I:
image

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions