fix: Use cursor position for navigation to arguments

- VS was passing line spans to ISuggestedActionsSource instead of cursor position
- Navigation provider now uses ITextView.Caret.Position when available
- Fixes navigation actions not appearing when cursor on template properties
- Update CHANGELOG for v0.7.2

Author: willibrandon

CHANGELOG.md

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.7.2] - 2025-09-21
+
+### Fixed
+- Navigation to arguments now properly uses cursor position
+  - Visual Studio was passing line spans instead of cursor position to ISuggestedActionsSource
+  - Navigation provider now correctly uses ITextView.Caret.Position for accurate cursor detection
+  - Fixes issue where navigation actions would not appear when cursor was on template properties
+
 ## [0.7.1] - 2025-09-21
 
 ### Fixed
@@ -322,6 +330,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Customizable colors via Tools > Options > Environment > Fonts and Colors
 - Real-time highlighting as you type
 
+[0.7.2]: https://github.com/willibrandon/serilog-syntax/releases/tag/v0.7.2
+[0.7.1]: https://github.com/willibrandon/serilog-syntax/releases/tag/v0.7.1
+[0.7.0]: https://github.com/willibrandon/serilog-syntax/releases/tag/v0.7.0
+[0.6.2]: https://github.com/willibrandon/serilog-syntax/releases/tag/v0.6.2
 [0.6.1]: https://github.com/willibrandon/serilog-syntax/releases/tag/v0.6.1
 [0.6.0]: https://github.com/willibrandon/serilog-syntax/releases/tag/v0.6.0
 [0.5.2]: https://github.com/willibrandon/serilog-syntax/releases/tag/v0.5.2

SerilogSyntax/Navigation/SerilogNavigationProvider.cs

@@ -70,13 +70,27 @@ public async Task<bool> HasSuggestedActionsAsync(
         return await Task.Run(() =>
         {
             DiagnosticLogger.Log("=== HasSuggestedActionsAsync called ===");
+
+            // VS seems to be passing the line span instead of cursor span
+            // Use the caret position if available, otherwise fall back to range
             var triggerPoint = range.Start;
+            if (textView != null && textView.Caret != null)
+            {
+                triggerPoint = textView.Caret.Position.BufferPosition;
+                DiagnosticLogger.Log($"Using caret position: {triggerPoint.Position}");
+            }
+            else
+            {
+                DiagnosticLogger.Log($"Using range start: {triggerPoint.Position}");
+            }
+
             var line = triggerPoint.GetContainingLine();
             var lineText = line.GetText();
             var lineStart = line.Start.Position;
 
             DiagnosticLogger.Log($"Line text: '{lineText}'");
             DiagnosticLogger.Log($"Trigger position: {triggerPoint.Position}");
+            DiagnosticLogger.Log($"Line start position: {lineStart}");
 
             // Check if we're in a Serilog call
             var serilogMatch = SerilogCallDetector.FindSerilogCall(lineText);
@@ -102,11 +116,12 @@ public async Task<bool> HasSuggestedActionsAsync(
             string template;
             int templateStartPosition;
             int templateEndPosition;
-            
+
             if (serilogCallLine == line)
             {
                 // Same-line scenario: template starts on the same line as the Serilog call
                 var templateMatch = FindTemplateString(lineText, serilogMatch.Index + serilogMatch.Length);
+                DiagnosticLogger.Log($"FindTemplateString result: {(templateMatch.HasValue ? $"Found at [{templateMatch.Value.Item1}, {templateMatch.Value.Item2}]" : "Not found")}");
                 if (!templateMatch.HasValue)
                 {
                     // No complete template found on this line - check if it's a multi-line template starting here
@@ -129,11 +144,18 @@ public async Task<bool> HasSuggestedActionsAsync(
                     template = lineText.Substring(templateStart, templateEnd - templateStart);
                     templateStartPosition = lineStart + templateStart;
                     templateEndPosition = lineStart + templateEnd;
-                    
+
+                    DiagnosticLogger.Log($"Template found: '{template}'");
+                    DiagnosticLogger.Log($"Template position: [{templateStartPosition}, {templateEndPosition}]");
+
                     // Check if cursor is within template
                     var positionInLine = triggerPoint.Position - lineStart;
+                    DiagnosticLogger.Log($"Position in line: {positionInLine}, template range in line: [{templateStart}, {templateEnd}]");
                     if (positionInLine < templateStart || positionInLine > templateEnd)
+                    {
+                        DiagnosticLogger.Log("Cursor is outside template bounds");
                         return false;
+                    }
                 }
             }
             else
@@ -154,13 +176,29 @@ public async Task<bool> HasSuggestedActionsAsync(
 
             // Parse template to find properties
             var properties = _parser.Parse(template).ToList();
-            
+            DiagnosticLogger.Log($"Found {properties.Count} properties in template");
+
             // Find which property the cursor is on
             var cursorPosInTemplate = triggerPoint.Position - templateStartPosition;
-            var property = properties.FirstOrDefault(p => 
-                cursorPosInTemplate >= p.BraceStartIndex && 
+            DiagnosticLogger.Log($"Cursor position in template: {cursorPosInTemplate}");
+
+            var property = properties.FirstOrDefault(p =>
+                cursorPosInTemplate >= p.BraceStartIndex &&
                 cursorPosInTemplate <= p.BraceEndIndex);
 
+            if (property != null)
+            {
+                DiagnosticLogger.Log($"Found property: {property.Name} at [{property.BraceStartIndex}, {property.BraceEndIndex}]");
+            }
+            else
+            {
+                DiagnosticLogger.Log("No property found at cursor position");
+                foreach (var p in properties)
+                {
+                    DiagnosticLogger.Log($"  Property '{p.Name}' at [{p.BraceStartIndex}, {p.BraceEndIndex}]");
+                }
+            }
+
             return property != null;
         }, cancellationToken);
     }
@@ -177,7 +215,14 @@ public IEnumerable<SuggestedActionSet> GetSuggestedActions(
         SnapshotSpan range,
         CancellationToken cancellationToken)
     {
+        // VS seems to be passing the line span instead of cursor span
+        // Use the caret position if available, otherwise fall back to range
         var triggerPoint = range.Start;
+        if (textView != null && textView.Caret != null)
+        {
+            triggerPoint = textView.Caret.Position.BufferPosition;
+        }
+
         var line = triggerPoint.GetContainingLine();
         var lineText = line.GetText();
         var lineStart = line.Start.Position;

SerilogSyntax/source.extension.vsixmanifest

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="SerilogSyntax.33851f71-44fa-46e0-9f66-e0f039ca2681" Version="0.1.0" Language="en-US" Publisher="mtlog" />
+    <Identity Id="SerilogSyntax.33851f71-44fa-46e0-9f66-e0f039ca2681" Version="0.7.2" Language="en-US" Publisher="mtlog" />
     <DisplayName>Serilog Syntax Highlighting</DisplayName>
     <Description>Provides syntax highlighting, navigation, and brace matching for Serilog message templates in C#/.NET projects. Supports all property types including standard, destructured, stringified, and positional properties.</Description>
     <MoreInfo>https://github.com/willibrandon/serilog-syntax</MoreInfo>