-
Notifications
You must be signed in to change notification settings - Fork 853
chore(main): release 1.590.0 #7309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(main): release 1.590.0 #7309
Conversation
Deploying windmill with
|
| Latest commit: |
5d4815a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce0dfe18.windmill.pages.dev |
| Branch Preview URL: | https://release-please--branches--ma.windmill.pages.dev |
|
Claude finished @rubenfiszel's task —— View job Review of Release PR #7309Todo List:
Overall AssessmentThis is an automated release PR generated by Release Please. The changes are minimal and appropriate for a patch version bump (1.589.3 → 1.589.4). ✅ What's Good
Code Quality ReviewCHANGELOG.md (frontend/CHANGELOG.md:3-9)✅ Excellent - The changelog entry is well-structured:
version.txt (version.txt:1)✅ Correct - Version bump from 1.589.3 to 1.589.4 is accurate Bug Fixes Included1. Frontend Flow Status Fix (#7308)Commit: a8d4073 What it fixes: Ensures the correct workspace script version is used when displaying flow status Code Quality: ✅ Good
Potential Issues: None identified - this is a straightforward bug fix 2. S3 ETag Caching Improvement (#7301)Commit: 7b1a8b0 What it fixes: Improves S3 etag caching mechanism by adding a Code Quality: ✅ Good
Concerns:
Security Considerations✅ No security concerns identified:
Performance ConsiderationsS3 Caching Fix: ✅ Positive impact
Flow Status Fix: ⚪ Neutral
Deployment Considerations
Testing & Reproduction InstructionsFor Bug Fix #7308 (Frontend Flow Status):To verify this fix, navigate to a flow detail page where a flow execution is in progress or has completed. Click on a flow step/node in the flow graph viewer. In the right panel, switch to the "Node Definition" tab. The script shown should now correctly display the version that was actually executed for that specific job run, rather than always showing the current workspace version of the script. This is particularly important when viewing historical flow runs where the script may have been updated since the flow executed. For Bug Fix #7301 (S3 ETag Caching):To verify the S3 caching improvement, create or edit a script or flow that uses caching (has a cache TTL set). In the script/flow settings, you should now see an option to configure whether the S3 path should be ignored for cache key calculation. When enabled, this allows cached results to be reused even when S3 resource paths change, as long as the actual code and arguments remain the same. Test by running a job with caching enabled, then modifying an S3 resource path used by the job, and running it again - with this option enabled, it should use the cached result. Recommendation✅ APPROVE - This release PR is ready to merge The changes are well-implemented, properly documented, and maintain backward compatibility. The database migration is safe and additive. Both bug fixes address real issues without introducing new risks. |
394b0c7 to
e1e7fe2
Compare
542aea0 to
e49526f
Compare
🤖 I have created a release beep boop
1.590.0 (2025-12-06)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.