Skip to content

Conversation

@rubenfiszel
Copy link
Contributor

@rubenfiszel rubenfiszel commented Dec 5, 2025

🤖 I have created a release beep boop

1.590.0 (2025-12-06)

Features

Bug Fixes


This PR was generated with Release Please. See documentation.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d4815a
Status: ✅  Deploy successful!
Preview URL: https://ce0dfe18.windmill.pages.dev
Branch Preview URL: https://release-please--branches--ma.windmill.pages.dev

View logs

@claude
Copy link
Contributor

claude bot commented Dec 5, 2025

Claude finished @rubenfiszel's task —— View job


Review of Release PR #7309

Todo List:

  • Read and analyze changed files
  • Review changelog accuracy
  • Review version bump
  • Check commit references
  • Provide comprehensive feedback
  • Add reproduction instructions

Overall Assessment

This is an automated release PR generated by Release Please. The changes are minimal and appropriate for a patch version bump (1.589.3 → 1.589.4).

✅ What's Good

  1. Proper Semantic Versioning: Patch version increment is appropriate for bug fixes only
  2. Accurate Changelog: Correctly documents the two bug fixes with proper links to PRs and commits
  3. Clean Release Process: Standard automated release workflow
  4. Well-Formatted: Follows conventional commit standards

Code Quality Review

CHANGELOG.md (frontend/CHANGELOG.md:3-9)

Excellent - The changelog entry is well-structured:

  • Clear version number and date
  • Proper comparison link to previous version
  • Categorized under "Bug Fixes"
  • Links to both PR numbers and commit SHAs
  • Descriptive commit messages with scope prefixes

version.txt (version.txt:1)

Correct - Version bump from 1.589.3 to 1.589.4 is accurate


Bug Fixes Included

1. Frontend Flow Status Fix (#7308)

Commit: a8d4073

What it fixes: Ensures the correct workspace script version is used when displaying flow status

Code Quality: ✅ Good

  • Clean prop drilling of jobScriptHash through component hierarchy
  • Proper TypeScript typing with optional fields
  • Minimal, focused changes
  • Correctly threads script_hash through the module state chain

Potential Issues: None identified - this is a straightforward bug fix

2. S3 ETag Caching Improvement (#7301)

Commit: 7b1a8b0

What it fixes: Improves S3 etag caching mechanism by adding a cache_ignore_s3_path option

Code Quality: ✅ Good

  • Comprehensive implementation across backend and frontend
  • Proper schema migration (20251204210743_cache_ignore_s3_path.up.sql)
  • Added to all relevant job payload types
  • OpenAPI spec updated
  • Consistent use of Option<bool> for nullable field

Concerns:

  • This is a large change (38 files, +337/-205 lines) for a patch release
  • Adds a database migration which has deployment implications
  • However, the field is optional with proper skip_serializing_if, ensuring backward compatibility ✅

Security Considerations

✅ No security concerns identified:

  • No exposure of sensitive data
  • Database migration is additive only
  • Optional fields maintain backward compatibility

Performance Considerations

S3 Caching Fix: ✅ Positive impact

  • Should improve cache hit rates by allowing S3 path to be ignored in cache key calculation
  • Reduces unnecessary re-computation when S3 paths change but content remains the same

Flow Status Fix: ⚪ Neutral

  • Minimal performance impact
  • Just passes existing data through component hierarchy

Deployment Considerations

⚠️ Important: This release includes a database migration

  • Migration: 20251204210743_cache_ignore_s3_path
  • The migration appears safe (additive only)
  • Rolling deployments should work fine due to optional field handling

Testing & Reproduction Instructions

For Bug Fix #7308 (Frontend Flow Status):

To verify this fix, navigate to a flow detail page where a flow execution is in progress or has completed. Click on a flow step/node in the flow graph viewer. In the right panel, switch to the "Node Definition" tab. The script shown should now correctly display the version that was actually executed for that specific job run, rather than always showing the current workspace version of the script. This is particularly important when viewing historical flow runs where the script may have been updated since the flow executed.

For Bug Fix #7301 (S3 ETag Caching):

To verify the S3 caching improvement, create or edit a script or flow that uses caching (has a cache TTL set). In the script/flow settings, you should now see an option to configure whether the S3 path should be ignored for cache key calculation. When enabled, this allows cached results to be reused even when S3 resource paths change, as long as the actual code and arguments remain the same. Test by running a job with caching enabled, then modifying an S3 resource path used by the job, and running it again - with this option enabled, it should use the cached result.


Recommendation

APPROVE - This release PR is ready to merge

The changes are well-implemented, properly documented, and maintain backward compatibility. The database migration is safe and additive. Both bug fixes address real issues without introducing new risks.

@rubenfiszel rubenfiszel changed the title chore(main): release 1.589.4 chore(main): release 1.590.0 Dec 5, 2025
@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch 4 times, most recently from 394b0c7 to e1e7fe2 Compare December 6, 2025 10:17
@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 542aea0 to e49526f Compare December 6, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants