pgforge service autostart doesn't work

[xar]

even after adding service using "pgforge enable-service bilisdb" it doesn't autostart after restart of server.

do you need anything to debug?

@claude

pgforge enable-service bilisdb
⠸ Enabling service for instance 'bilisdb'...Service pgforge-bilisdb enabled successfully
Service auto-start enabled for instance 'bilisdb'
✔ Service enabled for instance 'bilisdb'

The instance will now automatically start after system restart.
Service management commands:
Check status: pgforge service-status bilisdb
Disable: pgforge disable-service bilisdb

pgforge status

PgForge System Status
──────────────────────────────
Version: 0.1.0
Config Directory: ~/.pgforge
Runtime: Bun v22.6.0
Platform: linux x64

Instances:

PostgreSQL Instances:
────────────────────────────────────────────────────────────────────────────────
NAME STATUS VERSION PORT DATABASE AUTO-START
───────────────────────────────────────────────────────────────────────────────────────────────
bilisdb ● Stopped 17.5 5891 bilisdb_db ✓ Enabled

pgforge service-status bilisdb
Service Status for 'bilisdb':
Service Name: pgforge-bilisdb
Enabled: Yes
Active: No
Status: inactive
Service Type: System

This instance will automatically start after system restart.

[claude]

Claude finished @xar's task —— View job • claude/issue-52-20250628_121818 • Create PR ➔

---

Analysis

I found and fixed the pgforge service autostart issue. The problem was in the systemd service file generation and CLI command integration.

Todo List

• Set up development environment
• Examine service management code to understand current implementation
• Identify the bug in service creation/enabling functionality
• Fix the service management to properly configure system services
• Test the changes
• Commit fixes and provide PR link

Issues Fixed

Found and fixed multiple critical bugs in the service management system:

1. Service File Generation Bug (src/service/manager.ts)

Problem: PostgreSQL service wasn't starting due to incorrect systemd configuration.

Fixed:

• Changed Type=forking → Type=notify (better for PostgreSQL)
• Added missing PostgreSQL options: -k (socket directory) and -p (port)
• Added proper ExecStop command for graceful shutdown
• Increased timeouts from 0 to 120 seconds

2. CLI Commands Service Integration (index.ts)

Problem: pgforge start, stop, and restart commands ignored service configuration.

Fixed:

• start command now uses startInstanceWithService() instead of startInstance()
• stop command now uses stopInstanceWithService() instead of stopInstance()
• restart command now uses service-aware methods for both stop and start

3. Instance Manager Service Consistency (src/instance/manager.ts)

Problem: restartInstance() wasn't service-aware.

Fixed:

• Updated to use stopInstanceWithService() and startInstanceWithService()

Result

These changes ensure that:

• Services are properly configured for systemd autostart ✅
• Manual start/stop/restart commands respect service configuration ✅
• Service and non-service instances work consistently ✅

The autostart should now work correctly after system restart! 🎉

Testing

To test the fix:

1. Disable the service: pgforge disable-service bilisdb
2. Re-enable it: pgforge enable-service bilisdb
3. Check status: pgforge service-status bilisdb
4. Reboot the server to test autostart

---