From b424109945aa16f29459e25103b797d4b31d3b2d Mon Sep 17 00:00:00 2001
From: Matheus Martins <mathrm@gmail.com>
Date: Fri, 12 Jun 2026 11:00:29 +0000
Subject: [PATCH] ci(release): tolerate the PHAR smoke-test timeout under
 errexit

GitHub runs `run:` steps with `bash -eo pipefail`, so the bare
`timeout 10s php var/xphp-lsp.phar </dev/null; status=$?` aborted the
Smoke-test step the instant `timeout` returned 124 (server stayed up the
full window) -- before the "124 is a healthy boot" guard could run --
failing the release with exit 124.

Capture the exit code errexit-safely with `|| status=$?` so the guard is
honoured; a real boot failure (any other non-zero, e.g. an autoload
fatal) still fails the job as intended.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .github/workflows/release-phar.yml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/release-phar.yml b/.github/workflows/release-phar.yml
index 2650b9c..af8dc06 100644
--- a/.github/workflows/release-phar.yml
+++ b/.github/workflows/release-phar.yml
@@ -65,8 +65,14 @@ jobs:
         # non-zero status before reaching the read loop, failing the job.
         # `timeout` returning 124 (server stayed up the full window) is also
         # treated as a healthy boot.
+        #
+        # Capture the exit code with `|| status=$?`: GitHub runs steps under
+        # `bash -eo pipefail`, so a bare `timeout ...; status=$?` would abort
+        # the step the moment `timeout` exits 124 (errexit), never reaching
+        # the guard below. The `||` exempts it from errexit and records the code.
         run: |
-          timeout 10s php var/xphp-lsp.phar </dev/null; status=$?
+          status=0
+          timeout 10s php var/xphp-lsp.phar </dev/null || status=$?
           if [ "$status" -ne 0 ] && [ "$status" -ne 124 ]; then
             echo "PHAR failed to boot (exit $status)"
             exit 1