Skip to content

Commit aff82e7

Browse files
committed
Fix Kirk comments
1 parent cfad49e commit aff82e7

2 files changed

Lines changed: 8 additions & 18 deletions

File tree

taskfiles/lint-cpp.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,6 @@ tasks:
5858
aliases:
5959
- "cpp-static-fix"
6060
desc: "Runs the C++ static analyzers. Only checks for warnings and violations."
61-
sources:
62-
- "{{.G_CMAKE_CACHE}}"
63-
- "{{.G_COMPILE_COMMANDS_DB}}"
64-
- "{{.G_LINT_VENV_CHECKSUM_FILE}}"
65-
- "{{.G_CPP_SRC_DIR}}/**/*.cpp"
66-
- "{{.G_CPP_SRC_DIR}}/**/*.h"
67-
- "{{.G_CPP_SRC_DIR}}/**/*.hpp"
68-
- "{{.ROOT_DIR}}/.clang-tidy"
69-
- "{{.TASKFILE}}"
7061
deps:
7162
- ":build:init"
7263
- "cpp-configs"
@@ -77,7 +68,6 @@ tasks:
7768
FLAGS:
7869
- "--config-file '{{.ROOT_DIR}}/.clang-tidy'"
7970
- "-p '{{.G_COMPILE_COMMANDS_DB}}'"
80-
INCLUDE_FILENAME_PATTERNS: ["*.cpp", "*.h", "*.hpp"]
8171
OUTPUT_DIR: "{{.G_LINT_CLANG_TIDY_DIR}}"
8272
ROOT_PATHS: ["{{.G_CPP_SRC_DIR}}"]
8373
VENV_DIR: "{{.G_LINT_VENV_DIR}}"

taskfiles/lint-yaml.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ tasks:
1313
- "{{.TASKFILE}}"
1414
- exclude: "{{.ROOT_DIR}}/**/build/*"
1515
- exclude: "{{.ROOT_DIR}}/**/tools/*"
16-
# The following are for Clion's default generated build dirs
17-
- exclude: "{{.ROOT_DIR}}/cmake-build-debug/*"
18-
- exclude: "{{.ROOT_DIR}}/cmake-build-release/*"
16+
17+
# Exclude CMake build directories generated by CLion
18+
- exclude: "{{.ROOT_DIR}}/cmake-build-*"
1919
dir: "{{.ROOT_DIR}}"
2020
deps:
2121
- "venv"
@@ -26,11 +26,11 @@ tasks:
2626
\( \
2727
-path '**/build' \
2828
-o -path '**/tools' \
29-
-o -path '**/cmake-build-debug' \
30-
-o -path '**/cmake-build-release' \
29+
-o -path '**/cmake-build-*' \
3130
\) -prune -o \
3231
\( -iname "*.yaml" -o -iname "*.yml" \) \
3332
-print0 | \
34-
xargs -0 yamllint \
35-
--config-file "tools/yscope-dev-utils/exports/lint-configs/.yamllint.yml" \
36-
--strict
33+
xargs -0 \
34+
yamllint \
35+
--config-file "tools/yscope-dev-utils/exports/lint-configs/.yamllint.yml" \
36+
--strict

0 commit comments

Comments
 (0)