-
Notifications
You must be signed in to change notification settings - Fork 738
Parametrize tests with pools encryption #30242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces parametrized testing for pool encryption functionality by creating reusable fixtures that run tests with encryption both enabled and disabled. The changes enable a single test module to be automatically executed in both encrypted and non-encrypted configurations.
Key changes:
- Added parametrized fixtures for encryption testing that automatically run tests with encryption enabled/disabled
- Implemented auto-generation of encryption keys for test slots when pool encryption is enabled
- Updated configuration generator to apply encryption mode to storage pool types
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| ydb/tests/library/fixtures/init.py | Adds encryption_enabled parametrized fixture and ydb_cluster_configuration_with_encryption_parametrized fixture that extends cluster configuration with encryption settings |
| ydb/tests/library/harness/kikimr_runner.py | Implements auto-generation of encryption keys and configuration files for test slots when pool encryption is enabled |
| ydb/tests/library/harness/kikimr_config.py | Adds enable_pool_encryption parameter to KikimrConfigGenerator and configures encryption mode for storage pools in YAML config |
| ydb/tests/functional/tenants/test_auth_system_views.py | Updates ydb_configurator fixture to use the new encryption-parametrized configuration fixture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
15189f0 to
a4d1d6c
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog category
Description for reviewers
Parametrize one test for now: