Suggestions before our first release

[yorkie]

• Under https://github.com/yodaos-project/rt-node/tree/master/src, remove the prefix rtnode- and rename the rtev to uv, just curious why not using the name uv.
• Under https://github.com/yodaos-project/rt-node/tree/master/src/modules, remove the prefix rtnode-module.

At the codebase, renaming the below macros and functions are recommended:

• RTNODE_FUNCTION should be DEFINE_FUNCTION.
• rename the prefix rtnode to js, like js_object_to_string, js_object_set_method and js_object_set_property.

[yorkie]

Another points are:

• this should be moved to example directory: https://github.com/yodaos-project/rt-node/blob/master/src/js/app.js.
• the assert and events modules might be useless.
• document how to use it as library(static or shared) is required.
• document how to extend common modules is required.

[yorkie]

And we should follow this spec https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html instead of Node.js Timers, thus setImmediate() is unnecessary working on this project.

BTW, browser doesn't own the process object at https://github.com/yodaos-project/rt-node/blob/master/src/js/global.js#L6, to remove the process module, we have the following tasks:

• remove nextTick()
• remove memoryUsage()

These functions should be delivered from ecosystem or user-land.

[yorkie]

And we should follow this spec https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html instead of Node.js Timers, thus setImmediate() is unnecessary working on this project.

Sorry about that @lolBig, setImmediate() has its Web edition: https://developer.mozilla.org/en-US/docs/Web/API/Window/setImmediate, and a corresponding clearImmediate() should be here: https://developer.mozilla.org/en-US/docs/Web/API/Window/clearImmediate.

[qile222]

Here is what i think we have to do before first release, some are consistent with you @yorkie :

1. currently all js files are packaged in ./src/rtnode-snapshots.c, so we should provide an entry for user code. as you said, remove the src/js/app.js and load it from user side
2. module system only support load js which packaged in a c file, other ways like load from disk should be supported
3. resolve dependences between modules, if js from disk is supported, the module system should be able to resolve module from absolute or relative path
4. support native addon from user side

Other points like code style is not the highest priority, we can adjust it later.

Since rtev is not the same as uv, the definition and use of the API is also different, so use different names in order to avoid confusing them

[yorkie]

Other points like code style is not the highest priority, we can adjust it later.

I'm -1 on this, coding style is the higher priority for upcoming contributor, we should prepare them before this release.

Since rtev is not the same as uv, the definition and use of the API is also different, so use different names in order to avoid confusing them.

The rtev looks too long, make another short name looks good to me.

[qile222]

Other points like code style is not the highest priority, we can adjust it later.

I'm -1 on this, coding style is the higher priority for upcoming contributor, we should prepare them before this release.

Since rtev is not the same as uv, the definition and use of the API is also different, so use different names in order to avoid confusing them.

The rtev looks too long, make another short name looks good to me.

Done 🚚

[yorkie]

How about removing the app.js and process.js?

[qile222]

i will remove app.js after added user js code entry.
i think we should provide some APIs like memory usage for debugger, now they are in process.js, we can rename process.js to another

[yorkie]

i think we should provide some APIs like memory usage for debugger, now they are in process.js, we can rename process.js to another

Can we provide those at the other place like another npm package?