Skip to content

Auto-review: issues found in recent push #92

@ythx-101

Description

@ythx-101

Issue 1 — BUG: Multi-URL processing silently broken

  • File: scripts/run_qa.sh, lines 15–21
  • When multiple URLs are passed as arguments, URL_ARGS is built in the loop but never used. Line 21 passes only "$1" (the first URL) to qa_pipeline.py. All additional URLs are silently ignored.
# URL_ARGS is computed but discarded; only $1 is ever processed:
python3 "$SCRIPT_DIR/qa_pipeline.py" --url "$1" --output "$DATA_DIR/qa_data.json"

Issue 2 — BUG: Broken internal link

  • File: index.html, lines 356 and 367
  • Both link to memory-system.html, but that file does not exist in the repository. Only memory-system.md exists. The links are dead.

Issue 3 — SECURITY: Webhook delivered over plain HTTP

  • File: feeds/subscribers.json, line 15
  • The subscriber webhook URL is http://43.163.91.147:9378/teahouse-feed (plain HTTP). Discussion content pushed to this webhook is transmitted unencrypted and is susceptible to eavesdropping. Should be HTTPS.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions