Replies: 1 comment
-
|
This doesn't really make sense - the loading step is separate from the parsing step...
That makes more sense - we should definitely at least warn, if not ouright error if the user tries to load variables that don't exist!!! The faulty logic must be in here VirtualiZarr/virtualizarr/xarray.py Line 528 in ba1f464 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
While I think the new parser interface is really slick, it took me a while to realize that the round trip test (https://virtualizarr.readthedocs.io/en/stable/custom_parsers.html#testing-your-new-parser) suggested in the docs does not currently work with the VirtualTiff parser:
At least one reason for this is that unlike the common 'rasterio' engine to load GeoTiffs directly into memory, VirtualTiff does not currently parse coordinates (virtual-zarr/virtual-tiff#55). So the passing
loadable_variables=['x','y']toopen_virtual_datasethas no effect. Currently you have to do some manual tweaking of the virtualized format or adjust after loading to get the coordinates and spatial metadata to pass such a test.In any case, I don't think an identical match is necessary for a lot of use cases, but though it could be nice to issue some warning from
open_virtual_datasetif the requestedloadable_variablesaren't actually loaded?Beta Was this translation helpful? Give feedback.
All reactions