Fix AllowanceView crash due to paymaster interpret refetch (#671)

Author: everdimension

src/ui/components/address-action/TransactionConfirmationView/TransactionConfirmationView.tsx

@@ -50,6 +50,10 @@ export function TransactionConfirmationView({
 }) {
   const { preferences, query } = usePreferences();
 
+  // TODO:
+  // Refactor:
+  // refactor to a single hook that can interpret both regular
+  // and paymaster transactions
   const txInterpretQuery = useTxInterpretQuery({
     transaction,
     eligibilityQuery,

src/ui/components/address-action/TransactionSimulation/TransactionSimulation.tsx

@@ -144,9 +144,14 @@ export function TransactionSimulation({
 
   const { preferences } = usePreferences();
   const source = preferences?.testnetMode?.on ? 'testnet' : 'mainnet';
+  // TODO:
+  // Refactor:
+  // This must be called on the same level as `txInterpretQuery`
+  // in TransactionConfirmationView
   const paymasterTxInterpretQuery = useQuery({
     enabled: Boolean(network?.supports_simulations) && paymasterEligible,
     suspense: false,
+    keepPreviousData: true,
     queryKey: ['interpret/typedData', client, currency, transaction, source],
     queryKeyHashFn: (queryKey) => {
       const key = queryKey.map((x) => (x instanceof Client ? x.url : x));

src/ui/pages/SendTransaction/SendTransaction.tsx

@@ -605,6 +605,10 @@ function SendTransactionContent({
 
   const paymasterTxInterpretQuery = useQuery({
     enabled: Boolean(network?.supports_simulations) && paymasterEligible,
+    // Both paymasterTxInterpretQuery and txInterpret query must behave the same
+    // and keepPreviousData. Failing to do this currently may break AllowanceView
+    // component because we will pass a nullish requestedAllowanceQuantityBase during refetch
+    keepPreviousData: true,
     suspense: false,
     queryKey: [
       'interpret/typedData',