Updated Correlation Identifier

Author: zkavtaskin

eCommerce.WebService/App_Start/Installers/DistributedInterfaceLayerInstall.cs

@@ -17,7 +17,7 @@ public void Install(Castle.Windsor.IWindsorContainer container, Castle.MicroKern
                .BasedOn<IHttpController>()
                .Configure(c => c.LifestyleTransient()));
 
-            container.Register(Component.For<IRequestCorrelationIdentifier>().ImplementedBy<WebRequestCorrelationIdentifier>().LifeStyle.PerWebRequest);
+            container.Register(Component.For<IRequestCorrelationIdentifier>().ImplementedBy<W3CWebRequestCorrelationIdentifier>().LifeStyle.PerWebRequest);
         }
     }
 }

…Start/WebRequestCorrelationIdentifier.cs …rt/W3CWebRequestCorrelationIdentifier.cseCommerce.WebService/App_Start/WebRequestCorrelationIdentifier.cs renamed to eCommerce.WebService/App_Start/W3CWebRequestCorrelationIdentifier.cs eCommerce.WebService/App_Start/WebRequestCorrelationIdentifier.cs renamed to eCommerce.WebService/App_Start/W3CWebRequestCorrelationIdentifier.cs

@@ -1,40 +1,42 @@
-using eCommerce.Helpers.Logging;
-using System;
-using System.Security.Cryptography;
-using System.Text;
-using System.Web;
-
-namespace eCommerce.WebService.App_Start
-{
-    public class WebRequestCorrelationIdentifier : IRequestCorrelationIdentifier
-    {
-        public string CorrelationID { get; private set; }
-
-        public WebRequestCorrelationIdentifier()
-        {
-            /* #Customise your correlation ID here
-             * More request identification variables you add easier 
-             * it's going to be to find the relevant W3C request when you hash it
-             * 
-             * Below is just an example of variables and hash algorithm that you can use:
-             */
-            string rawCorrelationID = string.Join("_",
-                    HttpContext.Current.Request.ServerVariables["REMOTE_ADDR"],
-                    HttpContext.Current.Request.Params["LOGON_USER"],
-                    HttpContext.Current.Request.UserAgent.ToString(),
-                    HttpContext.Current.Request.Path,
-                    DateTime.Now.ToString("dd/MM/yyyy HH:mm:ss")
-                );
-
-            StringBuilder hashBuilder = new StringBuilder();
-            using (MD5 md5 = MD5.Create())
-            {
-                byte[] hash = md5.ComputeHash(Encoding.UTF8.GetBytes(rawCorrelationID));
-                for (int i = 0; i < hash.Length; i++)
-                    hashBuilder.Append(hash[i].ToString("X2"));
-            }
-
-            this.CorrelationID = hashBuilder.ToString();
-        }
-    }
+using eCommerce.Helpers.Logging;
+using System;
+using System.Security.Cryptography;
+using System.Text;
+using System.Web;
+
+namespace eCommerce.WebService.App_Start
+{
+    public class W3CWebRequestCorrelationIdentifier : IRequestCorrelationIdentifier
+    {
+        public string CorrelationID { get; private set; }
+
+        public W3CWebRequestCorrelationIdentifier()
+        {
+            /* #Customise your correlation ID here
+             * More request identification variables you add easier 
+             * it's going to be to find the relevant W3C request when you hash it
+             * 
+             * Below is just an example of variables and hash algorithm that you can use:
+             */
+            string rawCorrelationID = string.Join("_",
+                    HttpContext.Current.Request.ServerVariables["REMOTE_ADDR"],
+                    HttpContext.Current.Request.Params["LOGON_USER"],
+                    HttpContext.Current.Request.UserAgent != null ? 
+                        HttpContext.Current.Request.UserAgent.ToString().Replace(" ", "+") : "-",
+                    HttpContext.Current.Request.Path,
+                    HttpContext.Current.Request.QueryString.ToString() ?? "-",
+                    new DateTime(HttpContext.Current.Timestamp.Ticks).ToUniversalTime().ToString("yyyy-MM-dd HH:mm:ss")
+                );
+
+            StringBuilder hashBuilder = new StringBuilder();
+            using (MD5 md5 = MD5.Create())
+            {
+                byte[] hash = md5.ComputeHash(Encoding.UTF8.GetBytes(rawCorrelationID));
+                for (int i = 0; i < hash.Length; i++)
+                    hashBuilder.Append(hash[i].ToString("X2"));
+            }
+
+            this.CorrelationID = hashBuilder.ToString();
+        }
+    }
 }

eCommerce.WebService/eCommerce.WebService.csproj

@@ -148,7 +148,7 @@
   <ItemGroup>
     <Compile Include="App_Start\BootstrapConfig.cs" />
     <Compile Include="App_Start\FilterConfig.cs" />
-    <Compile Include="App_Start\WebRequestCorrelationIdentifier.cs" />
+    <Compile Include="App_Start\W3CWebRequestCorrelationIdentifier.cs" />
     <Compile Include="App_Start\Installers\ApplicationLayerInstall.cs" />
     <Compile Include="App_Start\Installers\DistributedInterfaceLayerInstall.cs" />
     <Compile Include="App_Start\Installers\DomainModelLayerInstall.cs" />