GitHub Actions OIDC token fallback#25
Draft
JakeHertenstein wants to merge 2 commits into0x77dev:mainfrom
Draft
Conversation
- Fetch fresh GA token with audience=sigstore when available - Fall back to provided token if GA environment unavailable - Minimal change: only reqwest dep + sign.rs GA token logic - No vendoring, no bloat—just 40 lines of code
- Fetch fresh GA token with audience=sigstore when available - Vendor sigstore 0.13.0 with relaxed JWT parsing (flexible audience/exp/nbf) - Fall back to provided token if GA environment unavailable - Prefer fresh GA token over supplied token in CI environments
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thanks for the pdf-sign project. I'm attempting to integrate this with a GitHub Action. But had trouble with OIDC. I believe there is an upstream problem with the sigstore bundle but I'm a bit out of my depth. I'm proposing as a draft for review. I had help from copilot and it 'works' on my workflow but needs another set of eyes...