Merged
Conversation
- Fix incorrect PATH instructions: midenup init creates miden symlink in $MIDENUP_HOME/bin, users need that directory in PATH - Fix wrong env var ($XDG_DATA_DIR) and wrong which miden expected output - Make Node.js version expectations generic (v22.x.x+) - Fix "Deploy Your Account" section (was showing miden client new-wallet instead of explaining it already deploys automatically) - Add note about "No artifact found" during midenup install being expected - Fix project creation redundancy (reference project from installation) - Add troubleshooting for old config file errors Closes #216
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
miden client new-walletalready deploys automatically, no separate deploy step neededv20.11.0to genericv22.x.xmidenup install(expected when no pre-built binaries available)Fixes #216