Store balance rank as integer instead of percentile #2419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Refactor from storing balance_rank_percentile (numeric 0-100) to storing raw balance_rank (integer, 0-based). This provides more flexibility for clients to calculate percentile, percentage, or other transformations on-demand using the formula: (rank / (total_count - 1)) * 100 Changes: - Column: balance_rank_percentile numeric(5,2) → balance_rank integer - Migration updated with new column name and type - Schema definition updated - Comment updated with client-side calculation guidance Example pattern from: supabase/migrations/20231017213200_add_index_to_distribution_shares.sql (line 2) which shows adding integer columns to distribution_shares table. Test plan: - Apply migration: supabase db push - Verify column: SELECT column_name, data_type FROM information_schema.columns WHERE table_name='distribution_shares' AND column_name='balance_rank' Expected: column_name='balance_rank', data_type='integer'
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 30, 2025
|
Vercel Unique URL: https://sendapp-hom3bwn11-0xsend.vercel.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Refactor from storing balance_rank_percentile (numeric 0-100) to storing
raw balance_rank (integer, 0-based). This provides more flexibility for
clients to calculate percentile, percentage, or other transformations
on-demand using the formula: (rank / (total_count - 1)) * 100
Changes:
Example pattern from: supabase/migrations/20231017213200_add_index_to_distribution_shares.sql (line 2)
which shows adding integer columns to distribution_shares table.
Test plan:
Expected: column_name='balance_rank', data_type='integer'