ci: publish PR web previews - #138
Conversation
| jobs: | ||
| deploy-preview: | ||
| name: Deploy web preview | ||
| if: github.event.pull_request.head.repo.full_name == github.repository |
There was a problem hiding this comment.
This condition skips the entire job whenever the PR head repository is a fork, which includes this PR. As a result, fork PRs never export, deploy, or receive a preview comment. If fork previews are intended to be supported, use a trigger/checkout design that preserves token safety while allowing the preview; otherwise this workflow should document that limitation rather than presenting itself as a general PR preview.
| } | ||
|
|
||
| const application = AndroidConfig.Manifest.getMainApplicationOrThrow(manifest); | ||
| application.$['android:usesCleartextTraffic'] = 'true'; |
There was a problem hiding this comment.
Setting android:usesCleartextTraffic to true on the application enables plaintext HTTP for every Android build, including release builds, not just the LAN ws:// use case mentioned in the comment. This weakens the release transport security and permits other app traffic to be downgraded/intercepted. Keep cleartext disabled for release builds and scope any LAN-development exception to a debug-only configuration.
Summary
Dependency