feat: add per-turn automatic translation delivery - #182
Open
Gwen317 wants to merge 1 commit into
Open
Conversation
| var stored Preference | ||
| err := r.pool.QueryRow(ctx, ` | ||
| INSERT INTO message_preferences (account_id,channel,enabled,verified,updated_at) | ||
| INSERT INTO message_preferences (account_id,channel,destination_ref,enabled,verified,updated_at) |
There was a problem hiding this comment.
The parameter order here is wrong: $3 is bound from preference.Enabled, but the third column is destination_ref. This will try to store a bool into the destination-ref column and swap the enabled/destination values for every preference write.
|
|
||
| // NewRealtimeAudioLanguageConfigReader preserves the full output route in the | ||
| // turn-start snapshot consumed by the media-plane pipeline. | ||
| func NewRealtimeAudioLanguageConfigReader(reader languages.LanguageConfigReader) (realtimeaudio.LanguageConfigReader, error) { |
There was a problem hiding this comment.
This adapter is only useful if the realtime runtime actually uses it. In this repo the manager still consumes session.LanguageConfigReader, and there is no call site for NewRealtimeAudioLanguageConfigReader, so OutputRoutes never reach the turn opener in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the confirmed design for Issue #176:
tts_enabledanddelivery_enabledindependently for each target language at Turn start.destination_refper channel and useauto:final_turn:{turn_id}:{channel}:{destination_ref}for idempotency.Verification
go test -count=1 -race ./...inpackages/contractsgo test -count=1 -race ./...inservices/apigo test -count=1 -race ./...inservices/realtime-audioRefs #176