[utils] Implemented Enumerate iterator adapter (#28)#29
Open
derzhavin3016 wants to merge 5 commits intomasterfrom
Open
[utils] Implemented Enumerate iterator adapter (#28)#29derzhavin3016 wants to merge 5 commits intomasterfrom
derzhavin3016 wants to merge 5 commits intomasterfrom
Conversation
Tako-San
reviewed
Jul 24, 2022
Tako-San
reviewed
Jul 24, 2022
- Removed class template specialization for rvalue reference by specifying storage type of container conditionally - Added tests for checking move semantic's work - Removed requirement of ::iterator type in container
- To prevent changing of counter, made it const in reference & value type - Removed useless dummy_ variable because of errors while using it
- Replaced makeEnumerate w/ ctor with deduction hint - Added size method for enumerate
derzhavin3016
force-pushed
the
enumerate
branch
from
58ca689 to
7d86497
Compare
- Added test with constant container - Removed const from reference & value_type - Removed operator!= for EnumerateIt (generated by default) - Renamed Enumer -> Enumerate
Member
Author
|
I think we can merge it after I add test for ordinary array as a container |
Tako-San
reviewed
Aug 9, 2022
Comment on lines
+43
to
+44
| using difference_type = | ||
| std::pair<std::make_signed_t<std::size_t>, typename std::iterator_traits<It>::difference_type>; |
Member
There was a problem hiding this comment.
Is it really should be a pair? Maybe just number is enough?
Tako-San
reviewed
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28