fix: skip tree rewriting when no visible trimming needed (#26)#31
Merged
fix: skip tree rewriting when no visible trimming needed (#26)#31
Conversation
- Move popstate listener inside PATCH_FLAG guard to prevent duplicate registration - Replace scroller non-null assertion with proper null check - Remove redundant configReceived early return in page-script - Align log prefix format to [LS:LEVEL] convention - Don't force-preserve visible first node as root anchor when trimming
When trimMapping returns visibleKept === visibleTotal, return the original response unmodified instead of rebuilding the tree. This preserves hidden nodes (system/tool/thinking) that ChatGPT may need for rendering Extended Thinking conversations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trimMapping()was destructively rewriting the conversation tree even when no visible messages needed trimming (limit >= visibleTotal). This stripped hidden nodes (system/tool/thinking) and rewired parent/children links, potentially breaking ChatGPT rendering for Extended Thinking conversations.page-script.ts: whenvisibleKept === visibleTotal, return the original response unmodifiedTest plan