fix: preserve kept hidden nodes in trimmed conversations#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thinking/toolnodes inside the kept suffix when trimming a conversation treepostMessagehandshake does not trigger a misleading warningWhy
Issue #34 reports large conversations breaking after reload, with the composer disappearing after the thread is loaded. The ready-timeout warning was a weak signal, but the deeper problem was that real trimming rebuilt the kept suffix as a visible-only chain and dropped hidden nodes that ChatGPT may still depend on for rendering.
Verification
npm testnpm run build:typesnpm run lintFixes #34.