Open
Conversation
1280px
requested changes
Feb 19, 2025
| <ConfigurationType>Application</ConfigurationType> | ||
| <UseDebugLibraries>false</UseDebugLibraries> | ||
| <PlatformToolset>v141_xp</PlatformToolset> | ||
| <PlatformToolset>v143</PlatformToolset> |
Owner
There was a problem hiding this comment.
First, thanks for PR!
We don't want to bump the toolset version so the program code will remain compile-able for Windows XP...
| // with the same command-line arguments as originally provided. | ||
| // Windows will only restart the application if it terminates unexpectedly. | ||
| // If the user closes the application normally, no restart will occur. | ||
| HRESULT hr = RegisterApplicationRestart(L"", 0); |
Owner
There was a problem hiding this comment.
...And, from what I've read, RegisterApplicationRestart function has only been implemented since Vista.
So, there should also be some sort of check whether it is available to link or not (otherwise it will probably crash on XP right after starting).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main.c: Implemented automatic application restart registration on unexpected termination, along with debug messages confirming successful registration. These modifications address the issue where the program would sometimes close unexpectedly.