-
Notifications
You must be signed in to change notification settings - Fork 58
Feature/issue 1508 semicolon extra and missing #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/issue 1508 semicolon extra and missing #1509
Conversation
add empty check
.../com.e1c.v8codestyle.bsl.ui/src/com/e1c/v8codestyle/bsl/ui/qfix/MethodSemicolonExtraFix.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl.ui/src/com/e1c/v8codestyle/bsl/ui/qfix/SemicolonMissingFix.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/messages.properties
Outdated
Show resolved
Hide resolved
Проверка на нахождение statement
contain -> contains
ReplaceEdit -> InsertEdit
bundles/com.e1c.v8codestyle.bsl.ui/src/com/e1c/v8codestyle/bsl/ui/qfix/SemicolonMissingFix.java
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/Messages.java
Show resolved
Hide resolved
...les/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/MethodSemicolonExtraCheck.java
Outdated
Show resolved
Hide resolved
.../com.e1c.v8codestyle.bsl.ui/src/com/e1c/v8codestyle/bsl/ui/qfix/MethodSemicolonExtraFix.java
Outdated
Show resolved
Hide resolved
...les/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/MethodSemicolonExtraCheck.java
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Show resolved
Hide resolved
Добавление пустых строк
Изменена проверка всех стейтменотов на проверку в методах
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Show resolved
Hide resolved
...les/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/MethodSemicolonExtraCheck.java
Outdated
Show resolved
Hide resolved
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/SemicolonMissingCheck.java
Outdated
Show resolved
Hide resolved
tests/com.e1c.v8codestyle.bsl.itests/resources/missing-semicolon-statement-after.bsl
Outdated
Show resolved
Hide resolved
...codestyle.bsl.itests/src/com/e1c/v8codestyle/bsl/check/itests/SemicolonMissingCheckTest.java
Show resolved
Hide resolved
MaksimDzyuba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нужно больше тестов, нужно поправить ошибку, что я нашел, не верно применена идея с "statement.eContainingFeature().isMany() && statement.eContainer() != null
&& statement.eContainer().eGet(statement.eContainingFeature()) instanceof List<?> statementCollection" ее нужно в метод checkSemicolon, и пропускать через нее хотя бы случаи
- else if (eObject instanceof IfStatement || eObject instanceof ForStatement)
- else if (eObject instanceof Statement & !(eObject instanceof EmptyStatement))
- else if (eObject instanceof SimpleStatement)
|
@MaksimDzyuba Я тоже хочу проверки писать на джава @alonthedark помоги среду настроить |
|
Что сделано
Чек-лист
Общее:
masterи нет конфликтовЕсли применимо:
Закрываемые задачи
Closes #1508