fix: manual disconnect not preventing reconnection#466
Open
SenseiHiraku wants to merge 1 commit into1c3t3a:mainfrom
Open
fix: manual disconnect not preventing reconnection#466SenseiHiraku wants to merge 1 commit into1c3t3a:mainfrom
SenseiHiraku wants to merge 1 commit into1c3t3a:mainfrom
Conversation
SenseiHiraku
changed the title
1c3t3a
requested changes
Nov 24, 2024
Owner
1c3t3a
left a comment
1c3t3a
left a comment
There was a problem hiding this comment.
Sorry for letting you wait so long!
This generally LGTM :) It would just be great if you could add a test for this behavior, so that we notice any regressions in the future. Also please rebase on the latest main, as there is not a merge conflict in one of the files.
Thanks a lot for your contribution and working on this. It is very much appreciated.
|
Why this hasn't been merged? Was this fixed? This seems to be a critical bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue where calling disconnect() on the client does not prevent the client from automatically reconnecting, as mentioned in #374
I noticed that the asynchronous client behaves differently since the
DisconnectReasonenum was introduced via #400. I have reimplemented this functionality for the synchronous client. During the process, I encountered issues such as "invoking disconnect after the client lost connection to the server still tries to reconnect," but I have fixed and tested every edge case I could think of, and all should be properly handled now.