Add async/sync ack methods for responding to emitWithAck calls#493
Open
dontcryme wants to merge 1 commit into1c3t3a:mainfrom
Open
Add async/sync ack methods for responding to emitWithAck calls#493dontcryme wants to merge 1 commit into1c3t3a:mainfrom
dontcryme wants to merge 1 commit into1c3t3a:mainfrom
Conversation
|
Pinging the maintainers. Could someone please review this PR? We really need this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added asynchronous and synchronous ack functions to enable responses since there was no way to respond with ack when called via emitWithAck. Additionally, I introduced a separate ack_id variable for response handling.
The code below was tested on a Node.js Socket.IO server using emitWithAck
Fixes #491