Change block data request to get witness block#548
Closed
randomlogin wants to merge 1 commit into2140-dev:masterfrom
Closed
Change block data request to get witness block#548randomlogin wants to merge 1 commit into2140-dev:masterfrom
randomlogin wants to merge 1 commit into2140-dev:masterfrom
Conversation
block() was sending Block instead of WitnessBlock. Probaby this was a regression introduced when the `filter-control` feature flag was removed (4ed9a55). The original code conditionally used `Inventory::WitnessBlock` under that feature; when the feature was removed the `WitnessBlock` path was lost and `Inventory::Block` became the unconditional default.
Collaborator
|
Most on-chain clients will not be doing block validation, so this would be a waste of bandwidth for some users. Can we instead add this as a |
Collaborator
|
I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author? |
Contributor
Author
You can use randomlogin76 at gmail |
Collaborator
|
Thanks, you are attributed in #549. Closing this now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change block data request to get witness block
Add a small test which might be unnecessary.
block() was sending Block instead of WitnessBlock.
ProbabLy this was a regression introduced when the
filter-controlfeature flag was removed (4ed9a55). The original code conditionally usedInventory::WitnessBlockunder that feature; when the feature was removed theWitnessBlockpath was lost andInventory::Blockbecame the unconditional default.Encountered this issue when tried to use kyoto for ldk-node (lightningdevkit/ldk-node#821).