Add fallback trying of both known and new peers#555
Open
randomlogin wants to merge 2 commits into2140-dev:masterfrom
Open
Add fallback trying of both known and new peers#555randomlogin wants to merge 2 commits into2140-dev:masterfrom
randomlogin wants to merge 2 commits into2140-dev:masterfrom
Conversation
AddressBook randomly choses use new or known peers, previously we didn't fallback to the known if we chose the new ones and the new happened to be empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered on regtest. Probably not common for a live network as we hopefully can easily find a new peer.
Previously it was the following:
If
tried.is_empty() = falseandnew.is_empty() = truewe skip the firstif, then we randomly chooseuse_tried = falsethen we skip the secondifdown toself.new.select()which fails asnew.is_empty() = true.Effectively this means if we cannot find a new peer there is a 50% chance we would not use the known ones and fail.
Not sure if we need a distinct test for that.