Skip to content

Fix half plane issues#94

Open
steven-murray wants to merge 4 commits into
better_lc_noisefrom
fix-half-plane-issues
Open

Fix half plane issues#94
steven-murray wants to merge 4 commits into
better_lc_noisefrom
fix-half-plane-issues

Conversation

@steven-murray
Copy link
Copy Markdown
Member

This is some work I'm doing to see if I can fix the half-plane vs full-plane issues. Just a draft for now as I'm working on it between this and the 21cmSense PR.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@steven-murray steven-murray changed the base branch from main to better_lc_noise June 7, 2026 17:35
@steven-murray steven-murray marked this pull request as ready for review June 8, 2026 02:00
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @steven-murray, your pull request is larger than the review limit of 150000 diff characters

@steven-murray steven-murray self-assigned this Jun 8, 2026
@steven-murray steven-murray added API Breaking Breaking Changes type: bug Something isn't working priority: high High priority labels Jun 8, 2026
@steven-murray
Copy link
Copy Markdown
Member Author

@nikos-triantafyllou this is finally ready for review -- there were a couple of small bugs on the 21cmSense side which are now fixed in a PR there (this branch adds the specific 21cmSense branch as a dependency... once you check this and give the all clear, I'll pull the trigger on the 21cmSense PR and update tuesday to depend on an actual 21cmSense version again).

@steven-murray
Copy link
Copy Markdown
Member Author

@nikos-triantafyllou it looks like it will fail tests until I merge and release the new 21cmSense, but you should be able to install it with uv properly locally (the CI fails because it uses miniconda+pip to handle deps rather than uv, which is fine usually but it doesn't pick up that 21cmSense is pointed to a git url rather than pypi). So, go ahead and look at it and test it out, and if you're satisfied, I'll merge upsteream.

BTW this does not attempt to fix #104 at all -- once this is merged into better_lc_noise, we can work on a fix from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Breaking Breaking Changes priority: high High priority type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant