Fix half plane issues#94
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Sorry @steven-murray, your pull request is larger than the review limit of 150000 diff characters
|
@nikos-triantafyllou this is finally ready for review -- there were a couple of small bugs on the 21cmSense side which are now fixed in a PR there (this branch adds the specific 21cmSense branch as a dependency... once you check this and give the all clear, I'll pull the trigger on the 21cmSense PR and update |
|
@nikos-triantafyllou it looks like it will fail tests until I merge and release the new 21cmSense, but you should be able to install it with BTW this does not attempt to fix #104 at all -- once this is merged into |
This is some work I'm doing to see if I can fix the half-plane vs full-plane issues. Just a draft for now as I'm working on it between this and the 21cmSense PR.