fix: remove automatic file filter when clicking Review #137
+1
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open source release of 1Code - Best UI for Claude Code with Local and Remote agent execution. Apache License 2.0
## What's New in v0.0.11 ### Changes - Renamed app from Agents to 1Code - Fixed appId to dev.21st.agents for auto-update compatibility - Prevent todo list flickering and improve streaming UX - Handle stale lock files from crashed instances - Show Open PR button when no uncommitted changes - Improved auto-update UX
## What's New in v0.0.12
### Features
- Drafts section in sidebar with preview and delete functionality
- Interrupted state for tools - shows "{toolName} interrupted" when stopping agent with ESC
- Tooltip with full file path when hovering over truncated filenames
- "See what's new" banner after app updates with link to changelog
### Improvements & Fixes
- Fixed sub-chat renaming not persisting to database
- Fixed editor focus after drag & drop image insertion
- Pending questions now bound to specific sub-chat (no longer appear in wrong chat)
- Fixed duplicate text in todo tool when status is in_progress
- Renamed "Premium support" button to "Feedback"
- Performance optimizations for pending questions
## What's New in v0.0.16 ### Improvements & Fixes - Fixed authentication redirect URL for packaged app - Fixed sidebar workspace timestamps updating on message send - Exclude session/plan files from changed files status bar - Reduced stop button icon size in send button
Adds ability to clone repos directly from GitHub by entering a URL or owner/repo format.
Repos are stored in userData/repos/{owner}/{repo}.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Stores cloned repos alongside worktrees for consistency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Shows "Clone from GitHub" button alongside "Select folder" during first-time setup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
## What's New in v0.0.18 ### Improvements & Fixes - Fixed sidebar flickering when switching between chats
## What's New ### Features - Added Cmd+Enter shortcut for "Implement plan" button - Improved archive popover: auto-unarchive on selection, input clears on revisit ### Fixes - Fixed sidebar flickering when switching between chats
## What's New ### Features - Added Cmd+Enter shortcut for "Implement plan" button - Improved archive popover: auto-unarchive on selection, input clears on revisit
## What's New ### Fixes - Fixed z-index layering for sticky user message bubble - Removed MCP servers indicator from header
Prevent message submission during IME composition (Chinese/Japanese/Korean input). Users can now use Enter to confirm IME candidate selection without triggering message send. Added isComposing check to both AgentsMentionsEditor and PromptInputTextarea components. Changes: - agents-mentions-editor.tsx: Add !e.nativeEvent.isComposing check - prompt-input.tsx: Add !e.nativeEvent.isComposing check
## What's New ### Fixes - Fixed scroll behavior: users can now scroll up freely during streaming - Fixed input lag by deferring trigger detection to next frame
Add animated GIF demos for key features: - Worktree isolation and background agent execution - Cursor-like UI with diff previews and git client - Plan mode with clarifying questions and structured plans Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fix IME composition issue with Enter key
Add animated GIF demos for key features: - Worktree isolation and background agent execution - Cursor-like UI with diff previews and git client - Plan mode with clarifying questions and structured plans Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move GIF assets to root assets/ directory and update paths in README. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
## What's New ### Fixes - Fixed scroll behavior: users can now scroll up freely during streaming - Fixed input lag by deferring trigger detection to next frame - Fixed tool display state during streaming
## What's New ### Features - Added scroll-to-bottom button with Cmd+↓ hotkey - Archive now kills terminal processes and deletes worktree ### Fixes - Fixed excessive re-renders in sidebar during scroll - Restored copy and play buttons for AI messages - ESC now skips AskQuestion instead of stopping stream - Show full command in collapsed tool view - Fixed tool display state during streaming
Update download URL to include binary name
fix: Add author email in package.json for .deb package generation
Add clone from GitHub feature
## What's New ### Features - Desktop notifications toggle in settings - easily enable/disable system notifications - Chat export via context menu - download or copy to clipboard in Markdown, JSON, or Plain Text formats (supports both full workspace and individual sub-chat export) ### Improvements & Fixes - Improved notification throttling with priority system --- Thanks to @cyxzdev for the original implementation of desktop notifications and chat export (#47)
## What's New ### Improvements & Fixes - **Plan Mode UI** — Improved plan mode UI and sidebar refetch - **Auto-scroll Fix** — Allow user to disable auto-scroll during scroll animation - **Todo List Fix** — Fixed infinite loop in todo list useEffect
## What's New - Desktop app release v0.0.38 ## Downloads - **macOS ARM64 (Apple Silicon)**: Download the `-arm64.dmg` file - **macOS Intel**: Download the `.dmg` file (without arm64) Auto-updates are enabled. Existing users will be notified automatically.
## What's New ### Improvements & Fixes - **Notifications Fix** — Filter notifications by chatId to prevent spam - **Per-Workspace Sidebars** — Plan and terminal sidebars are now per-workspace - **Error Handling** — Improved Claude SDK error handling and categorization - **Thinking Tokens** — Reduced max thinking tokens to prevent exceeding limit - **Paste Handling** — Updated paste text handling improvements - **MCP Auth** — Authentication improvements for MCP
## What's New ### Features - **Details Sidebar** — New unified Details sidebar with configurable widgets
## What's New ### Features - **Large Text Paste** — Auto-convert large pasted text to file attachments ### Improvements & Fixes - **Details Sidebar** — Improved caching, Plan widget expand, and UI updates - **Plan Indicator** — Fixed pending plan indicator (use mode as source of truth) - **Tooltip Fix** — Hide tooltip when workspace/chat is archived
fix: insert slash commands without auto-sending When selecting a slash command from suggestions (via Tab, Enter, or click), the command is now inserted into the input field instead of being sent immediately. This allows users to add arguments after the command before sending. State-changing commands (/clear, /plan, /agent, /compact) still execute immediately as they don't require additional input.
fix: custom slash commands fail silently with multi-line arguments The regex used to parse slash command arguments was missing the 's' (dotAll) flag, causing '.' to not match newline characters. When a custom command was invoked with multi-line arguments, the regex failed silently. Additionally, active-chat.tsx was entirely missing the slash command expansion logic that new-chat-form.tsx already had, so custom commands with arguments never worked in ongoing conversations. Fixes: - Add 's' flag to regex so '.' matches newlines in arguments - Add case-insensitive command name matching - Add missing slash command expansion in active-chat.tsx
## What's New ### Features - **Drag & Drop File Mentions** — Drag files to chat with hidden content support - **Custom Hotkeys in Tooltips** — Tooltips now show your custom keyboard shortcuts - **Sidebar Mutual Exclusion** — Sidebars auto-restore when switching between them ### Improvements & Fixes - **MCP OAuth Fix** — Fixed authentication for servers with client allowlists - **Relative Paths** — Show relative paths instead of absolute in UI - **Slash Commands** — Fixed multi-line arguments and auto-send behavior - **Cmd+R Disabled** — Prevent accidental page refresh - **Pasted Text Fix** — Sanitize pasted text preview to fix mention parsing
* feat: human-readable worktree folder names Replace cryptic base36 IDs with readable names for worktree directories: - Worktree folders now use adjective-landscape pattern (e.g., "golden-meadow") - Project folders now use the sanitized project name (e.g., "lumpos-saas") Before: ~/.21st/worktrees/mksuo7x8o4j231wz/mkt3o6tuipqprfwl/ After: ~/.21st/worktrees/lumpos-saas/golden-meadow/ Backward compatible: existing worktrees continue to work via dual-lookup strategy in resolveProjectPathFromWorktree(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address PR review feedback - Add short projectId suffix to sanitized project names to prevent slug collisions (e.g., "My Project" and "my_project" now produce distinct folder names like "my-project-abc123" vs "my-project-def456") - Truncate sanitized project names to 50 chars to avoid filesystem path length limits - Add database index on chats.worktree_path for faster lookups in resolveProjectPathFromWorktree() - Document TOCTOU race condition as acceptable (180k combinations, git worktree add fails atomically on collision) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: remove projectId suffix from project folder names Slug collisions (e.g., "My Project" and "my_project" → "my-project") are safe because resolveProjectPathFromWorktree() resolves via the full chats.worktreePath (unique per chat), not the project folder name alone. Keeps the 50-char truncation for filesystem safety. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
## What's New ### Features - **Multi-Window Support** — Open chats in new windows via context menu - **VS Code Theme Import** — Import themes from VS Code, Cursor, and Windsurf - **Human-Readable Worktree Names** — Worktree folders now have readable names ### Improvements & Fixes - **Window-Scoped Sidebars** — Sub-chat and details sidebars are now per-window - **Image Drops** — Handle image drops as attachments, not file mentions - **Plan Refetch** — Fixed plan refetch trigger with subChatId
## What's New ### Features - **Kanban Board View** — New Kanban board view for managing workspaces - **Voice Input** — Voice dictation with OpenAI Whisper API - **Extensible Mention Providers** — Add custom mention providers for @ mentions - **Custom Hotkeys in Context Menus** — Your keyboard shortcuts now show in context menus ### Improvements & Fixes - **Kanban UI** — Smaller, centered columns for better layout - **Plan Indicator** — Removed PlanIcon from plan update status indicator - **Kanban Settings** — Hide Kanban hotkey in settings when feature is disabled
When typing a command prefix, suggestions now appear sorted by name length (shortest first). This makes the closest match appear first. Example: typing "ape" now shows "/apex" before "/apex-analyze". Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
- Add right-click context menu for terminal with copy/paste support - If text is selected: copies to clipboard and shows toast notification - If no selection: pastes from clipboard - Fix Ctrl+V paste by intercepting the key to prevent xterm showing ^v and letting Electron's menu paste role handle it via paste event - Works on both Windows and macOS Co-authored-by: Claude <noreply@anthropic.com>
Prevent SQLite migration crash on startup. `0005_marvelous_master_chief.sql` may run `ALTER TABLE sub_chats DROP COLUMN ...` on DBs where these columns never existed, causing `SQLITE_ERROR: no such column` and aborting migrations. Remove the unsafe DROP COLUMN statements (keep index creation). Related: 15ee551 (PR #87) - https://github.com/paul-bouzian/1code/blob/15ee55107f3eefbf012fb9754484f987b9fbf399/drizzle/0005_marvelous_master_chief.sql#L1-L4 - https://github.com/paul-bouzian/1code/blob/15ee55107f3eefbf012fb9754484f987b9fbf399/drizzle/meta/_journal.json#L40-L46
* feat: add platform provider abstraction for cross-platform support
Introduce a platform provider pattern to centralize all platform-specific
logic (Windows, macOS, Linux) in one place. This fixes Windows shell
command execution issues and improves maintainability.
Changes:
- Add platform provider interface and implementations for Windows, macOS, Linux
- Refactor cli.ts to use platform provider for CLI installation
- Refactor terminal/env.ts to use platform provider for shell detection
- Refactor claude/env.ts to use platform provider for environment building
- Refactor claude-token.ts to use platform provider for PATH extension
- Fix path separator issues (use path.basename instead of split('/'))
The platform provider handles:
- Shell configuration and detection
- PATH building with common tool locations
- Environment variable setup
- CLI installation/uninstallation
- Locale detection
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: address PR review feedback
Based on PR #80 review by @serafimcloud:
1. Windows PATH limitation (Critical):
- Remove `setx PATH` which has 1024 char limit and can truncate PATH
- CLI install dir is already in buildExtendedPath() for app usage
- Return pathHint for users who want terminal access
2. Variable shadowing (Critical):
- Rename `path` to `filePath` in chats.ts to avoid shadowing
the imported `path` module
3. Electron coupling (Medium):
- Remove unused `app` import from windows.ts
- Remove unused `exec`, `promisify`, `lstatSync` imports
4. execCommand consistency (Low):
- Add documentation explaining execCommand is for simple commands
- Complex shell commands (osascript, pipes) may use exec directly
Co-Authored-By: Claude <noreply@anthropic.com>
* fix(windows): install CLI to ~/.local/bin instead of %LOCALAPPDATA%
- Install to ~/.local/bin which is already in buildExtendedPath()
- Avoids needing to modify system PATH or prompt user
- App can find CLI automatically via extended PATH
- Users with ~/.local/bin in their PATH can use it from terminal too
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
## What's New ### Features - **Multi-Account Support** — Switch between multiple Anthropic accounts - **Remote Sandbox Chats** — Full support for remote sandbox chats - **Default Agent Mode** — Set default agent mode preference with per-chat mode isolation — thanks @serafimcloud! (#102) - **Batch Discard** — Multi-select files for batch discard in changes view - **Terminal Copy/Paste** — Improved terminal copy/paste support on Windows — thanks @ChrisPei! (#91) ### Improvements & Fixes - **Command Autocomplete** — Sort by name length for better UX — thanks @paul-bouzian! (#93) - **SQLite Migration Fix** — Prevent crash on sub_chats drop column — thanks @a3my! (#100) - **Cross-Platform Support** — Add platform provider abstraction — thanks @ChrisPei! (#80) - **Theme Selector** — Add scroll and max-height to dropdown - **Kanban View** — Various fixes and improvements
## What's New ### Improvements & Fixes - **Chat Stability** — Improved chat remounting and migration idempotency - **Selected Text Indicator** — Show "Using selected text" bubble for pasted text attachments - **UI Polish** — Updated spinner icons and selectors to match desktop style
## What's New ### Improvements & Fixes - **MCP Cache Fix** — Fixed MCP caching issues - **Tool UI Polish** — Improved expand button spacing in bash/edit tools - **Onboarding Cleanup** — Removed welcome dialog and streamlined sidebar
## What's New ### Bug Fixes - **Startup Crash Fix** — Fixed "Cannot find module async-mutex" error that prevented app from launching
## What's New ### Features - **Copy Plan** — Copy plan content to clipboard - **Raw Plan View** — View raw markdown of implementation plans ### Improvements & Fixes - **New Subchat Button** — Fixed blocked state for add subchat button - **Message Store** — Include meta in message store state - **Community PRs** — Merged community contributions (#117, #118)
FIX: Reply Sends To Wrong Sub-Chat In Multi-Chat Workspace
## What's New ### Features - **Automations & Inbox** — New automations and inbox pages (beta — enable in Settings → Beta) - **Open in Editor** — Open worktree workspaces directly in your code editor ### Improvements & Fixes - **Expired Questions UX** — Keep expired AskUserQuestion visible and send answers as messages — thanks @jjjrmy! (#121) - **Default Model Fix** — Fixed chat UI disabled state when creating new chat with wrong default model
When clicking the Review button in the diff sidebar, a sub-chat filter was automatically applied (filteredSubChatIdAtom set to activeSubChatId), causing a "Filtered" badge to appear and hiding files not associated with the active sub-chat. This was confusing as users didn't expect or request the filtering. The review should operate on all changes by default; users can still manually apply a sub-chat filter if needed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
filteredSubChatIdAtomto the active sub-chat, causing a "Filtered" badge to appear and hiding unrelated files — this was confusing and unexpectedTest plan
🤖 Generated with Claude Code