Skip to content

Fix/#472 3-2차 스프린트 1차 QA 반영 #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
y-eonee merged 2 commits into from
Jul 17, 2026
Merged

Fix/#472 3-2차 스프린트 1차 QA 반영 #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f31ff10
fix: #472 아이콘 터치 영역 수정
y-eonee Jul 12, 2026
8cfb72a
refactor: #472 중복 로그인 방지
y-eonee Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Login/View/LoginView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,13 @@ final class LoginView: BaseView {
appleLoginButton.do {
$0.setImage(.appleLoginButton, for: .normal)
$0.alpha = 0
$0.isExclusiveTouch = true
}

kakaoLoginButton.do {
$0.setImage(.kakaoLoginButton, for: .normal)
$0.alpha = 0
$0.isExclusiveTouch = true

@dev-domo dev-domo Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중복 터치를 막아주는군요!

}
}

Expand Down
4 changes: 3 additions & 1 deletion ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Login/ViewController/LoginViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,14 @@ extension LoginViewController{
@objc
private func kakaoLoginButtonDidTap() {
rootView.kakaoLoginButton.isUserInteractionEnabled = false
rootView.appleLoginButton.isUserInteractionEnabled = false
self.platform = .KAKAO
viewModel.action(.socialLoginButtonDidTap(platform: .KAKAO))
}

@objc
private func appleLoginButtonDidTap() {
rootView.kakaoLoginButton.isUserInteractionEnabled = false
rootView.appleLoginButton.isUserInteractionEnabled = false
self.platform = .APPLE
viewModel.action(.socialLoginButtonDidTap(platform: .APPLE))
Expand Down
11 changes: 10 additions & 1 deletion ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Login/ViewModel/LoginViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ final class LoginViewModel: NSObject {
}

private var cancellables = Set<AnyCancellable>()

private var isSocialLoginInProgress = false

private let socialLoginUseCase: SocialLoginUseCase
private let getIsRegisteredUseCase: GetIsRegisteredUseCase
private let getUserIDUseCase: GetUserIDUseCase
Expand Down Expand Up @@ -60,7 +61,15 @@ extension LoginViewModel {

extension LoginViewModel {
private func socialLogin(platform: LoginPlatform) {
guard !isSocialLoginInProgress else {
ByeBooLogger.debug("이미 진행중인 요청 있음")
return
}
isSocialLoginInProgress = true

Task {
defer { isSocialLoginInProgress = false }

@dev-domo dev-domo Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task 안에도 defer문 선언이 가능하군요! 배워갑니다


do {
let _ = try await socialLoginUseCase.execute(platform: platform)
socialLoginAuthSubject.send(.success(()))
Expand Down
7 changes: 6 additions & 1 deletion ...-iOS/ByeBoo-iOS/Presentation/Feature/Quest/View/CommonQuest/Common/QuestContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,15 @@ final class QuestContentView: BaseView {
$0.spacing = 4.adjustedW
}
}
likeContainerView.do {
let tapRecognizer = UITapGestureRecognizer(target: self, action: #selector(likeButtonDidTap))
$0.addGestureRecognizer(tapRecognizer)
$0.isUserInteractionEnabled = true
}
likeButton.do {
$0.setImage(.heartOff, for: .normal)
$0.setImage(.heartOn, for: .selected)
$0.addTarget(self, action: #selector(likeButtonDidTap), for: .touchUpInside)
$0.isUserInteractionEnabled = false
}
commentIcon.do {
$0.image = .comment
Expand Down
Loading