Skip to content

Fix/#478 댓글 작성 시 공백만 있을 때 완료버튼을 누를 수 없도록 수정 - #479

Merged
y-eonee merged 1 commit into
developfrom
fix/#478-공백댓글작성불가
Jul 28, 2026

Hidden character warning

The head ref may contain hidden characters: "fix/#478-\uacf5\ubc31\ub313\uae00\uc791\uc131\ubd88\uac00"
Merged

Fix/#478 댓글 작성 시 공백만 있을 때 완료버튼을 누를 수 없도록 수정#479
y-eonee merged 1 commit into
developfrom
fix/#478-공백댓글작성불가

Conversation

@y-eonee

@y-eonee y-eonee commented Jul 24, 2026

Copy link
Copy Markdown
Member

🔗 연결된 이슈

📄 작업 내용

  • 댓글 작성 시 공백만 있을 때 완료버튼을 누를 수 없도록 수정했습니다.
구현 내용 IPhone 13 mini
GIF Simulator Screen Recording - iPhone 13 mini - 2026-07-25 at 02 35 52

Summary by CodeRabbit

  • 버그 수정
    • 댓글 입력란에 공백이나 줄바꿈만 입력한 경우 확인 버튼이 활성화되지 않도록 개선했습니다.
    • 실제 내용이 입력된 경우에만 버튼 상태와 글꼴 색상이 활성화됩니다.

@y-eonee y-eonee self-assigned this Jul 24, 2026
@y-eonee y-eonee added 나연🐹 fix 버그나 오류 해결 labels Jul 24, 2026
@y-eonee y-eonee linked an issue Jul 24, 2026 that may be closed by this pull request
1 task
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: be43fec5-f454-415a-a0a4-32c5c87e3312

📥 Commits

Reviewing files that changed from the base of the PR and between b5f97fb and f52289f.

📒 Files selected for processing (1)
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Quest/View/CommonQuest/Common/CommentTextView.swift

Walkthrough

댓글 입력값의 앞뒤 공백과 개행을 제거한 뒤 내용 존재 여부를 판단하도록 변경했습니다. 공백이나 개행만 입력하면 확인 버튼이 비활성화되고 비활성 상태 색상이 적용됩니다.

Changes

댓글 입력 검증

Layer / File(s) Summary
댓글 입력 상태 판정
ByeBoo-iOS/.../CommentTextView.swift
textViewDidChange(_:)가 공백과 개행을 제거한 입력을 기준으로 hasText를 계산하도록 변경되어 확인 버튼 상태와 글꼴 색상이 조정됩니다.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: juri123123, dev-domo

Poem

깡충 뛰는 토끼가 댓글을 보니
공백만 남은 칸은 살며시 닫고
알찬 글씨가 들어오면
확인 버튼을 밝혀 주네
당근처럼 깔끔한 입력이에요 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 공백만 입력된 댓글에서 완료 버튼이 비활성화되도록 하는 변경을 정확히 설명하는 제목입니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#478-공백댓글작성불가

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dev-domo dev-domo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어푸!

@y-eonee
y-eonee merged commit 29ba1b0 into develop Jul 28, 2026
2 checks passed
@y-eonee
y-eonee deleted the fix/#478-공백댓글작성불가 branch July 28, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 버그나 오류 해결 나연🐹

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] 공백일 때 댓글 달 수 없도록 함

3 participants