Skip to content

Conversation

@vijaiaeroastro
Copy link
Collaborator

Surface is listed as an object type in the core spec.

image

But it is missing in the lib3mf.xml.
This PR introduces it.

Fixes #440
Closes 3MFConsortium/lib3mf_python#8

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.66%. Comparing base (59e82bc) to head (bc2915c).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #442   +/-   ##
========================================
  Coverage    59.66%   59.66%           
========================================
  Files           64       64           
  Lines        24646    24646           
========================================
  Hits         14705    14705           
  Misses        9941     9941           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gangatp gangatp merged commit 4aec635 into develop Dec 12, 2025
42 checks passed
@vijaiaeroastro vijaiaeroastro deleted the fix/surfaceObjectType branch December 12, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants