Support namespaces on CAS operations#309
Open
fangel wants to merge 2 commits into3rd-Eden:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing some work on atomic updates to Memcache using CAS, and ran it an issue when you have namespaces enabled in your Memcached-client: The namespace would still be present in the object that is returned.
So when you have a namespace
foo:and do aclient.gets('bar', function(err, res) { ... })then the response-object contains{cas: ?, 'foo:bar': ?}instead of the expected{cas: ?, bar: ?}.I've updated the namespace tests to also included a successful CAS-write with a namespace and added a handle-function to the
gets-function that strips the namespace off of the full key.Kind regards
Morten