Dz2#4
Open
NataliaYakubenko wants to merge 2 commits into
Open
Conversation
48x
reviewed
May 14, 2018
| @@ -0,0 +1,31 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <module org.jetbrains.idea.maven.project.MavenProjectsManager.isMavenModule="true" type="JAVA_MODULE" version="4"> | |||
Owner
There was a problem hiding this comment.
Что-то ты не то закоммитила. Тесты где? :)
48x
reviewed
May 16, 2018
| GroupGetUserGroupsV2Response groupGetUserGroupsV2Response = okApi.getGroupService().getUserGroupsV2(); | ||
| LOGGER.info("Проверим, что в ответе есть группы"); | ||
| Assert.assertEquals("Совпадает userId","561744237296",groupGetUserGroupsV2Response.getGroups().get(1).getUserId()); | ||
| Assert.assertNotNull("Количество групп не 0",groupGetUserGroupsV2Response.getGroups().size()); |
Owner
There was a problem hiding this comment.
size коллекции не может быть null.
Можно саму коллекцию проверить на то, что она не null
| api.app.public.key= | ||
| api.app.secret.key= | ||
| api.app.public.key=CBAMKNHMEBABABABA | ||
| api.app.secret.key=1389F636CEE9435FAFDEA07F |
Owner
There was a problem hiding this comment.
Секретные ключи от своего приложения лучше не палить :)
| Assert.assertEquals("Совпадает userId","561744237296",groupGetUserGroupsV2Response.getGroups().get(1).getUserId()); | ||
| Assert.assertNotNull("Количество групп не 0",groupGetUserGroupsV2Response.getGroups().size()); | ||
| Assert.assertFalse("Пустой список групп",groupGetUserGroupsV2Response.getGroups().isEmpty()); | ||
| Assert.assertTrue("Содержит инофрмацию Anchor",groupGetUserGroupsV2Response.getGroups().contains(groupGetUserGroupsV2Response.getAnchor())); |
Owner
There was a problem hiding this comment.
Это очень странная проверка, смысл которой от меня скрыт. Ты проверяешь, что в списке групп есть служебный параметр anchor, которого в списке групп никогда не будет
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Жалкие попытки