Tcibisov tests#6
Open
Corsay wants to merge 1 commit into
Open
Conversation
Corsay
changed the title
48x
reviewed
May 21, 2018
Owner
48x
left a comment
48x
left a comment
There was a problem hiding this comment.
Есть несколько похожих ошибок во многих тестах. В остальном всё хорошо
| try { | ||
| LOGGER.info("Вызовем метод в сессии пользователя"); | ||
| bindDefaultUserSession(); | ||
| LOGGER.info("Вызовем метод с некорректным uids"); |
Owner
There was a problem hiding this comment.
Авторизацию лучше вытащить из try-catch. По возможности в этом блоке надо распологать только код, при выполнении которого ожидается ошибка. Логирование тоже можно вынести, но допускается и в try-catch
| LOGGER.info("Вызовем метод в сессии пользователя"); | ||
| bindDefaultUserSession(); | ||
|
|
||
| Integer count = COUNT_INCORRECT; |
Owner
There was a problem hiding this comment.
Можно и не вводить новую переменную count, а использовать COUNT_INCORRECT
|
|
||
| LOGGER.info("Проверим, что в ответе есть группы"); | ||
| List<UserGroupBean> userGroupBean = groupGetUserGroupsV2Response.getGroups(); | ||
| Assert.assertNotNull("Получили null вместо списка групп", userGroupBean); |
Owner
There was a problem hiding this comment.
CollectionUtils.isEmpty() уже проверяет коллекцию на null, так что эта проверка лишняя
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Dmitriy Tcibisov