Домашнее задание 3 Ширшова Настя#7
Open
captainger wants to merge 4 commits into
Open
Conversation
48x
reviewed
May 21, 2018
Owner
48x
left a comment
48x
left a comment
There was a problem hiding this comment.
Ради Христа, ставь пробелы после запятых
| Assert.assertFalse("Пустой список групп", CollectionUtils.isEmpty(groupGetUserGroupsV2Response.getGroups())); | ||
|
|
||
| LOGGER.info("Проверим, что в ответе есть anchor"); | ||
| Assert.assertFalse("Получили пустой anchor", groupGetUserGroupsV2Response.getAnchor().isEmpty()); |
Owner
There was a problem hiding this comment.
Можно упасть с NPE. Лучше проверять через StringUtils.isNotBlank
| #User session settings | ||
| user.session.access.token= | ||
| user.session.secret.key= | ||
| user.session.access.token=tkn18dPU47oSSZC1jMGRvnNyRozOMs5sIwhnhhsETm3WfB9gOWnrrJm4WXqnqQfpbfYj6 |
Owner
There was a problem hiding this comment.
Пароли, ключи и сессионные данные лучше в гит не заливать.
Author
|
Простите за запятые, я просто уже совсем обленилась с visual studio code |
48x
approved these changes
May 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.