Conversation
Owner
Author
|
@yungyuc |
|
Good findings. When adding your findings into the presentation, make sure you address all the assessing points for grading. Where in the code you want my review? Please make inline annotation. Don't hesitate to merge the PR. Review and discussions still work after merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the investigation in ISSUE #30 , it was found that LUT GEMM suffers from high L1 cache miss rates, making memory latency the performance bottleneck rather than computation. Several optimizations were applied, such as prefetching the LUT into L1 cache and tiling the matrices to avoid loading overly large chunks that cause cache misses. Additionally, multithreading was introduced to further improve performance. The original naive implementation was also updated to support multithreading, making it easier to compare performance under a fixed thread count.
Lastly,
tests/test_matrix_ops.cppwas added to help dump the assembly of both the naive (float) and LUT GEMM versions for comparison.