fix: add resource limits, PodDisruptionBudgets, and backup error handling#427
Open
fix: add resource limits, PodDisruptionBudgets, and backup error handling#427
Conversation
Change PDBs from minAvailable:1 to maxUnavailable:1 so single-replica workloads don't block node drains and cluster upgrades. Bump API and Hasura memory limits from 512Mi to 1Gi and CPU from 500m to 1000m to handle NestJS+BullMQ+WebSocket and Hasura subscription load.
lukepolo
reviewed
Apr 9, 2026
base/api/deployment.yaml
Outdated
| memory: "256Mi" | ||
| cpu: "250m" | ||
| limits: | ||
| memory: "1Gi" |
Contributor
There was a problem hiding this comment.
for larger installs no. do max 4gb
Contributor
Author
There was a problem hiding this comment.
Bumped API memory limit to 4Gi in ffa968e.
lukepolo
reviewed
Apr 9, 2026
base/hasura/deployment.yaml
Outdated
| memory: "256Mi" | ||
| cpu: "250m" | ||
| limits: | ||
| memory: "1Gi" |
Contributor
There was a problem hiding this comment.
way too little , in a production instance i have 4 GB. lets lmit to 4gb
Contributor
Author
There was a problem hiding this comment.
Bumped Hasura memory limit to 4Gi in ffa968e.
Contributor
|
also not a fan of CPU limits. we are not concerned enough here to starve these . memory limits on thse si mostly too low. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|| truefromapk add, add pg_dump output validation, add S3 upload error checkingAddresses #415 and #416
Test plan