fix: add script error handling, clean up Redis config, add graceful shutdown#428
Open
fix: add script error handling, clean up Redis config, add graceful shutdown#428
Conversation
CS2 demo files can be 100-300MB+. The previous 100M limit would cause 413 errors on demo uploads. 500M accommodates large demos while still being much safer than the original 4G.
lukepolo
reviewed
Apr 9, 2026
| name: api | ||
| namespace: 5stack | ||
| annotations: | ||
| nginx.ingress.kubernetes.io/proxy-body-size: "4G" |
Contributor
There was a problem hiding this comment.
no , for demos. needs to be bigger
lukepolo
reviewed
Apr 9, 2026
| # Persistence strategy: hybrid RDB snapshots + AOF for durability. | ||
| # RDB provides point-in-time snapshots; AOF provides write-level durability. | ||
| tcp-keepalive 240 | ||
| appendonly no |
Contributor
There was a problem hiding this comment.
these are required for queues
Contributor
Author
There was a problem hiding this comment.
Restored appendonly no and save "" in 1d2a406.
lukepolo
reviewed
Apr 9, 2026
install.sh
Outdated
| @@ -1,4 +1,5 @@ | |||
| #!/bin/bash | |||
| set -euo pipefail | |||
Contributor
There was a problem hiding this comment.
while testing this seems to break things
Contributor
Author
There was a problem hiding this comment.
Removed set -euo pipefail and reverted the error-handling wrappers in 1d2a406.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -euo pipefailtoinstall.shwith error checks after K3s install and kubectl node labelingsetup-env.sh(non-empty, no spaces)appendonly noandsave ""lines from Redis config that were overridden later in the same fileupdateStrategy: RollingUpdatewithmaxUnavailable: 1to connector DaemonSetterminationGracePeriodSeconds: 30to API, Hasura, and Connector pod specsAddresses #417, #418, and #419
Test plan
install.shexits on K3s install failuresetup-env.shrejects empty or space-containing domain names