fix: add lifecycle cleanup hooks and error handling for async operations#141
Open
fix: add lifecycle cleanup hooks and error handling for async operations#141
Conversation
Add OnApplicationShutdown to RedisManagerService to clear health check intervals and disconnect Redis on shutdown. Cap recursive setTimeout retries in assignServer to 10. Replace void fire-and-forget patterns with .catch() error handlers in AppModule, SocketsService, and MatchesModule.
lukepolo
reviewed
Apr 9, 2026
src/matches/matches.module.ts
Outdated
| }, | ||
| ); | ||
| ) | ||
| .catch((err) => { |
Contributor
There was a problem hiding this comment.
id rather error the whole process.
Contributor
Author
There was a problem hiding this comment.
Reverted all .catch() patterns back to void fire-and-forget across matches.module.ts, app.module.ts, and sockets.service.ts — unhandled rejections will now crash the process as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnApplicationShutdowntoRedisManagerServiceto clear health check intervals and disconnect Redis on shutdownsetTimeoutretries inMatchAssistantService.assignServerto 10 attemptsvoidfire-and-forget patterns with.catch()error handlers inAppModule,SocketsService, andMatchesModuleCloses 5stackgg/5stack-panel#375, 5stackgg/5stack-panel#376
Test plan