fix: add error handling for K8s API, Redis pipeline, demos, and config validation#10
Open
fix: add error handling for K8s API, Redis pipeline, demos, and config validation#10
Conversation
- NetworkService: track IP check interval and spawned bash processes, add OnApplicationShutdown to clear interval and kill processes, kill monitor on error/stderr, remove process.on(SIGTERM) handler - Throttle: store setInterval ID, add destroy() method to clear it - RconService: only store connection after successful auth, add timeout to rcon.send() calls, clear connection timer after successful connect - RedisManagerService: track health check intervals, add OnApplicationShutdown to clear intervals and disconnect
lukepolo
reviewed
Apr 9, 2026
| } | ||
|
|
||
| const metrics = await this.metricsClient.getNodeMetrics(); | ||
|
|
Contributor
There was a problem hiding this comment.
undo t his.k there is no value to set a const
Contributor
Author
There was a problem hiding this comment.
Reverted -- put the .find() back inline in the return object.
lukepolo
reviewed
Apr 9, 2026
| const safeName = nic.replace(/[^a-zA-Z0-9_.-]/g, ""); | ||
|
|
||
| const monitor = spawn("bash", [ | ||
| "-c", |
Contributor
There was a problem hiding this comment.
im not confident in merging this.
Contributor
Author
There was a problem hiding this comment.
Removed the NIC name sanitization entirely.
lukepolo
reviewed
Apr 9, 2026
| done`, | ||
| ]); | ||
|
|
||
| process.on(process.env.DEV ? "SIGUSR2" : "SIGTERM", () => { |
Contributor
There was a problem hiding this comment.
this is required for local dev.
Contributor
Author
There was a problem hiding this comment.
Restored the process.on(DEV ? 'SIGUSR2' : 'SIGTERM') signal handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNode()K8s API call and handle undefined fromgetNodeMetrics()void redis.multi().exec()withawait+ try/catch + error logging in WebRTC latency storagermdirSync(path, {recursive:true})withrmSync(path, {recursive:true})and addexistsSyncguards beforeunlinkSyncin demos serviceparseIntcalls in API config to fail fast on missing env varscontinueif invalidAddresses 5stackgg/5stack-panel#410 and 5stackgg/5stack-panel#411
Test plan