fix: add proper resource disposal for HttpClient, WebSocket, timers, and pending messages#137
Open
fix: add proper resource disposal for HttpClient, WebSocket, timers, and pending messages#137
Conversation
…and pending messages Wrap HttpClient in using statement in MatchService.GetMatchFromApi. Dispose _retryTimer and _webSocket in MatchEvents.Disconnect. Dispose old WebSocket before replacement in Connect. Cap _pendingMessages at 1000 entries. Clear entire _disconnectTimers dictionary in SurrenderSystem.Reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpClientinusingstatement inMatchService.GetMatchFromApi()_retryTimerand_webSocketinMatchEvents.Disconnect(); dispose old WebSocket inConnect()before replacement_pendingMessagesat 1000 entries to prevent unbounded growth_disconnectTimersdictionary inSurrenderSystem.Reset()Closes 5stackgg/5stack-panel#398
Test plan