Extract delete command #420
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor: extract delete and deletion-related commands (such as change) from the insert function into a new function named `deleteSelections` Testing: ``` yarn test ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: extract delete and deletion-related commands (such as change) from the insert function into a new function named
deleteSelectionsContext:
For #376 I wanted to modify how deletion behaves slightly. It took me a while to understand how deletion actually works in dance (basically, you're pasting an empty string into your selection) and thought that having a separate command would make things more understandable.
Testing:
Note that all tests still pass without modifying them.