Fixes #4 - Integrated TravisCI#16
Open
harshanas wants to merge 3 commits into99x-incubator:masterfrom
Open
Conversation
dinukadesilva
suggested changes
Aug 29, 2017
.travis.yml
Outdated
| @@ -0,0 +1 @@ | |||
| language:node_js | |||
There was a problem hiding this comment.
@harshanas
You have to specify nodejs versions and a script too. (test script is optional. But, it's nice to specify that too)
Eg:-
language: node_js
node_js:
- 6.2.2
script:
- npm test
Contributor
Author
There was a problem hiding this comment.
@dinukadesilva node version added . Thank you :)
|
As a best practice, it's nice to have each commit an atomic change. So, how about if you merge all these commits to a one commit with a meaningfull message. |
| @@ -0,0 +1,8 @@ | |||
| sudo: false | |||
|
|
|||
There was a problem hiding this comment.
Im not really certain whether we really need this line.
sudo: false
dinukadesilva
approved these changes
Aug 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #4