You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lands the code-review polish @adamhsparks authored on review/ahs.
Commits are preserved verbatim under their original authorship; no
history rewriting, no squash.
8f6ace8 replace "i" with i in cli_() calls and use rlang::match_arg(), faster
d82eee4 lint initial delay, specify integer
019963e lint cli messages
ade53aa ensure user inputs are all upper or lowercase as desired
c300561 redocument
Known follow-up (to be handled in a second PR)
rlang::arg_match(tolower(backend)) (the single-line form on this
branch) errors under current rlang because arg_match() requires
a symbol, not a call. Fix is a trivial two-line split
(x <- tolower(x); rlang::arg_match(x)) — already prepared on audit/2026-04-19 which will follow this PR. Does not block merge.
Merge discipline
Please use "Create a merge commit" or "Rebase and merge" — not
squash. Squash-merge collapses all 8 commits into one authored by
whoever clicks the button, which would erase @adamhsparks's
authorship on main.
review/ahs should stay on the remote after merge as a contribution
record. Branch cleanup is @adamhsparks's call.
Heads-up: once this lands, audit/2026-04-19 follows as a second PR. It
rebases on top of this branch and adds the CRAN-readiness scaffold
(collaboration surface, CITATION.cff / codemeta.json, macos-14 ARM CI
leg, lint + dependency-review workflows, httptest2 REST mocks, cli
snapshot tests), addresses review comments #1 and #3 from #1, adds a
Layer-1 live-GEE integration suite (7 opt-in tests + weekly workflow),
and fixes the two-line form of rlang::arg_match() noted in the PR
description.
Review comment #2 on #1 (yyjsonr over jsonlite) is deferred to a
separate performance PR — documented in audit_2026-04-19.md on the
audit branch so it won't get lost.
Happy to push audit/2026-04-19 to the remote now if you'd like to
review both in parallel, or wait until this merges and push a clean
rebased branch — your call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the code-review polish @adamhsparks authored on
review/ahs.Commits are preserved verbatim under their original authorship; no
history rewriting, no squash.
What this PR contains
Eight commits from @adamhsparks, in order:
4d2c7b9add air formatter supportcde3f00format with aira12e6d6format DESCRIPTION and fix Adam's email8f6ace8replace "i" with i in cli_() calls and use rlang::match_arg(), fasterd82eee4lint initial delay, specify integer019963elint cli messagesade53aaensure user inputs are all upper or lowercase as desiredc300561redocumentKnown follow-up (to be handled in a second PR)
rlang::arg_match(tolower(backend))(the single-line form on thisbranch) errors under current
rlangbecausearg_match()requiresa symbol, not a call. Fix is a trivial two-line split
(
x <- tolower(x); rlang::arg_match(x)) — already prepared onaudit/2026-04-19which will follow this PR. Does not block merge.Merge discipline
squash. Squash-merge collapses all 8 commits into one authored by
whoever clicks the button, which would erase @adamhsparks's
authorship on
main.review/ahsshould stay on the remote after merge as a contributionrecord. Branch cleanup is @adamhsparks's call.
Test plan
R CMD checkstill passes on this branch as-is.Addresses (partially) #1.