feat: axis masking via cross-axis constraints (#31)#40
Draft
MacdonaldJoshuaCaleb wants to merge 1 commit intomainfrom
Draft
feat: axis masking via cross-axis constraints (#31)#40MacdonaldJoshuaCaleb wants to merge 1 commit intomainfrom
MacdonaldJoshuaCaleb wants to merge 1 commit intomainfrom
Conversation
Add cross-axis constraint normalization infrastructure: - _validate_constraint_axes(): validates axes list per constraint rule - _resolve_constraint_mode(): determines allow/exclude mode - _validate_constraint_rule(): validates individual rule mappings - _normalize_constraints(): main entry point, parses and validates the constraints block from a spec dict Each constraint rule must reference at least two axes, specify either 'allow' or 'exclude' (not both), and only reference known axes/coords. Also adds PLC2701 to test per-file-ignores in pyproject.toml to allow importing private helpers for direct unit testing. Tests: 14 new tests covering happy paths and error cases. Refs: #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
constraintsblock to filter Cartesian product expansion, avoiding empty compartments.Issues
Refs #31