Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache intermediate results to avoid excessive file I/O and XML parsing. This is particularly noticeable when doing a quick read to get the metadata from a
LoggedDataobject (grower/farm/field, operation type, crop, date etc).Refactorings break down as follows:
ExtensionMethods.GetDirectoryFiles. CurrentlyGetDirectoryFilesenumerates all files on every call to find a single file and can be called many times forISOTimeLog.GetTimeElement(each looking up aTLGnnnnn.xml), plus additional calls for .bin files inTimeLogMapper.ReadTimeLogandFillDPDGeometryDefinitions. Every call re-enumerates the same directory. Create a simple dictionary to hold previous results, and clear at the end of eachplugin.Import()andplugin.Export()call.ISO11783_TaskData.ReadXML.ProcessExternalNodesis called for 15 different XML element prefixes. Each call potentially checks the directory for matching files, but most datasets only have external files forTSK.ISOTimeresults fromISOTimeLog.GetTimeElement. The method is called multiple times from 4 different callers; each call re-reads and re-parses the sameTLGnnnnn.xmlfile.RepresentationinRepresentationmapper. CurrentlyRepresentationMapper.Map()does a linear LINQ scan over ~600+ representations on every DDI lookup. With many timelogs and 10-20 data elements each, it can be hundreds of scans.DevicePropertiesby DDI inDeviceHierarchyElementto avoid scanningDevicePropertiesmultiple times for different DDI's.