Added enable/ disable logging api in Manager class - #8
Merged
Conversation
JennToo
reviewed
Jan 13, 2021
JennToo
left a comment
JennToo
left a comment
Member
There was a problem hiding this comment.
Very sorry for the delay! I seem to have missed the notification for this pull request.
Co-authored-by: Jennifer Wilcox <nat1192@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
- Coverage 82.22% 82.04% -0.18%
==========================================
Files 8 8
Lines 557 557
Branches 63 63
==========================================
- Hits 458 457 -1
- Misses 78 79 +1
Partials 21 21
Continue to review full report at Codecov.
|
JennToo
approved these changes
Jan 14, 2021
Member
|
Thanks for the contribution! We should get this out in the next release. I'll try to bundle it with the changes from #9 in the next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.