File set membership - #48
Draft
nginocchio wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is an attempt to address #41 by utilizing a hash set for detecting file membership primarily in
get_index_segment_path. The profile which @bicarlsen uploaded showed thatJPKReader.get_index_segment_pathwas a significant portion of load_data's compute time. This is primarily because when called fromget_index_segment_numbersfor every index and segment pair, a path which doesn't exist is linearly searched through the entirety of an archive's files.By utilizing a set to search for this file this can be accomplished in constant time.
I also created a helper function to initially cache an index's header properties so for every segment the properties can be copied from.
These two changes reduced the overall runtime of loading bicarlsen's sample data from about ~40 minutes to 4 minutes on my machine.
Please let me know if you have any questions in regards to this approach, or if there is something I missed.
Thanks