chore: remove unused pylint inline pragmas#371
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 9 9
Lines 1354 1354
=======================================
Hits 1350 1350
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ssrhaso
force-pushed
the
chore/remove-pylint-pragmas
branch
from
86e7789 to
40fbf92
Compare
Contributor
Author
|
Removed redundant .keys() call on line 401 of acro_stata_parser.py.. (Codacy Static Code Analysis flagged as error) |
Contributor
Author
|
@rpreen Please take a look at this when you get a chance |
rpreen
reviewed
Mar 25, 2026
test/test_stata17_interface.py
Outdated
Comment on lines
4
to
5
| # file this file and the file test_stata_interface.py have a lot of similarities. | ||
| # That is because we are testing the same functions for different versions of Stata. |
Collaborator
There was a problem hiding this comment.
Can you remove this comment that references pylint since it no longer applies?
Collaborator
|
Also while here can we clean up the last inline noqas since we want to move all the rule suppressions to acro/acro_regression.py
141: *args, # noqa: B026
261: *args, # noqa: B026
381: *args, # noqa: B026 |
ssrhaso
force-pushed
the
chore/remove-pylint-pragmas
branch
from
40fbf92 to
b310784
Compare
Contributor
Author
|
@rpreen Changes made
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rpreen
Removed all # pylint: disable=... and # pylint: skip-file inline pragmas from the codebase.
No logic, function signatures, or imports were changed. All pre-commit hooks pass.
Ref #348