Add a simple test that only reads partial frames to check proper cleanup#713
Open
tmadlener wants to merge 3 commits intoAIDASoft:masterfrom
Open
Add a simple test that only reads partial frames to check proper cleanup#713tmadlener wants to merge 3 commits intoAIDASoft:masterfrom
tmadlener wants to merge 3 commits intoAIDASoft:masterfrom
Conversation
Reading only part of the collections stored in a frame should not lead to leaked memory (see e.g. AIDASoft#500). The tests that are added in this commit are targetting that, specifically by running them with sanitizers enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
This is a followup on #500 and the discussion from yesterdays Key4hep meeting to actually add a test case that checks that there are indeed no leaks when only part of the collections are requested from a Frame.